From a3c189e54f2e007f99cb949fdfbaa9f69365b420 Mon Sep 17 00:00:00 2001
From: Andrew Butterfield <abutterfield@instructure.com>
Date: Tue, 20 Jan 2015 09:41:46 -0700
Subject: [PATCH] Groups membership from student perspective fixed
fixes CNVS-18055
Test plan:
* As a teacher create a few groups within a few group sets that have
self signup enabled
* As a student, go to the groups page and join/switch to/leave some of
these groups
* Ensure that the joinability of the groups in the group set update
properly
* Ensure that this works when a group does not have a student leader
Change-Id: Ia1f52beb5dd97afc5f43ee7eb161e4ebd6f2b979
Reviewed-on: https://gerrit.instructure.com/47463
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Andrew Butterfield <abutterfield@instructure.com>
---
app/jsx/groups/StudentView.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/jsx/groups/StudentView.jsx b/app/jsx/groups/StudentView.jsx
index d016c5637f3..dec0a227ee5 100644
--- a/app/jsx/groups/StudentView.jsx
+++ b/app/jsx/groups/StudentView.jsx
@@ -127,7 +127,7 @@ define([
groupModel.set('users', _.reject(groupModel.get('users'), (u) => u.id === userId ));
// If user was a leader, unset the leader attribute.
var leader = groupModel.get("leader");
- if (leader.id == userId) {
+ if (leader && leader.id == userId) {
groupModel.set("leader", null);
}
},