Fix analytics pagination caused by jQuery bug

Fixes: ADMIN-2950

See: https://github.com/ryankshaw/jquery/commit/637babee7ed47a532c962d
For the actual fix

Test plan:
* root cause check:
Open your browser devtools:
Type: $(window).is(':hidden')
That should return `false` and not throw this error:
Uncaught TypeError: Cannot read property 'defaultView' of undefined

Type: $(window).is(':visible')
That should return `true` and not throw this error:
Uncaught TypeError: Cannot read property 'defaultView' of undefined

Manual check for the jira
 - have analytics plugin configured
 - have more than 10 students enrolled in a course
 - scroll down in course analytics
 - students beyond the first 10 should appear as you scroll

Change-Id: I0e6e3ae2f8b5758f02611273018b751b9e20f758
Reviewed-on: https://gerrit.instructure.com/211192
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This commit is contained in:
Ryan Shaw 2019-09-26 15:17:53 -06:00
parent 24646fbdfd
commit a159af4d52
2 changed files with 7 additions and 1 deletions

View File

@ -40,4 +40,10 @@ describe "jquery" do
expect(driver.execute_script("return $('form').attr('method', 'delete').attr('method')").downcase).to eq "post"
expect(driver.execute_script("return $('form input[name=_method]').val()")).to eq "delete"
end
it "should be able to handle ':hidden' and ':visible' pseudo-selector on window" do
get('/login')
expect(driver.execute_script("return $(window).is(':visible')")).to eq true
expect(driver.execute_script("return $(window).is(':hidden')")).to eq false
end
end

View File

@ -12299,7 +12299,7 @@ jquery.elastic@1.0.0:
jquery@2.x, jquery@>=1.2.6, jquery@>=1.5, jquery@>=1.7.1, "jquery@https://github.com/ryankshaw/jquery.git#1.7.2-with-AMD-and-CommonJS":
version "1.7.2"
resolved "https://github.com/ryankshaw/jquery.git#ce59a7f0b3c4fc6ff9a2176f853e64eed6d826a8"
resolved "https://github.com/ryankshaw/jquery.git#637babee7ed47a532c962d1dce0094a098ed7c7d"
js-base64@^2.1.8, js-base64@^2.1.9, js-base64@^2.4.3:
version "2.5.1"