ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename Homeroom (dashboard) to Home 

closes LS-2502
flag = none

Test plan:
 - String is 'Home' not 'Homeroom' in global nav, mobile global nav,
   and in browser title

Change-Id: Ic1e839f3a12e1a286a0c167a77f9e557eaf364de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271095
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
This commit is contained in:
Jackson Howe 2021-08-10 11:19:36 -06:00
parent 512eddcd5b
commit a103324421
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/shared/_new_nav_header.html.erb
View File

@ -24,7 +24,7 @@
<%
if k5_user?
dashboard_title = t('Homeroom')
dashboard_title = t('Home')
dashboard_icon_path = "shared/svg/svg_icon_home.svg"
courses_title = t('Subjects')
else

2
app/views/users/user_dashboard.html.erb
View File

@ -18,7 +18,7 @@
<%
if k5_user?
dashboard_title = t('Homeroom')
dashboard_title = t('Home')
else
dashboard_title = t('Dashboard')
end

2
spec/selenium/navigation_spec.rb
View File

@ -160,7 +160,7 @@ describe 'Global Navigation' do
it 'should be called homeroom and subjects with k5 on' do
toggle_k5_setting(@course.account)
get "/courses/#{@course.id}"
expect(f('#global_nav_dashboard_link .menu-item__text').text).to eq 'Homeroom'
expect(f('#global_nav_dashboard_link .menu-item__text').text).to eq 'Home'
expect(f('#global_nav_courses_link .menu-item__text').text).to eq 'Subjects'
end
end

4
ui/features/navigation_header/react/MobileGlobalMenu.js
View File

@ -126,7 +126,7 @@ export default class MobileGlobalMenu extends React.Component {
<Heading>
<a className="ic-brand-mobile-global-nav-logo" href="/">
<span className="screenreader-only">
{this.props.k5User ? I18n.t('Homeroom') : I18n.t('My Dashboard')}
{this.props.k5User ? I18n.t('Home') : I18n.t('My Dashboard')}
</span>
</a>
</Heading>
@ -145,7 +145,7 @@ export default class MobileGlobalMenu extends React.Component {
</Flex.Item>
<Flex.Item>
<Text size="medium">
{this.props.k5User ? I18n.t('Homeroom') : I18n.t('Dashboard')}
{this.props.k5User ? I18n.t('Home') : I18n.t('Dashboard')}
</Text>
</Flex.Item>
</Flex>