remove visible traces of anonymous peer reviews
refs #3341 there is some backend support for anonymous peer reviews but it was never finished and exposed in the UI, except for when posting a peer review via ajax. this removes the visible traces of the feature until it can be completed. test plan: - leave a peer review comment on an assignment - when the comment is inserted into the page, the author should be your name, rather than 'Anonymous' Change-Id: I8ecaf4ab8941b4c0f3f80605445d7361ed2b2747 Reviewed-on: https://gerrit.instructure.com/12171 Tested-by: Jenkins <jenkins@instructure.com> Reviewed-by: Cody Cutrer <cody@instructure.com>
This commit is contained in:
parent
5ac7b56684
commit
9fc42cde44
|
@ -235,7 +235,6 @@ class Assignment < ActiveRecord::Base
|
|||
self.all_day_date = (zoned_due_at.to_date rescue nil) if !self.all_day_date || self.due_at_changed? || self.all_day_date_changed?
|
||||
self.submission_types ||= "none"
|
||||
self.peer_reviews_assign_at = [self.due_at, self.peer_reviews_assign_at].compact.max
|
||||
self.anonymous_peer_reviews = true if self.peer_reviews
|
||||
@workflow_state_was = self.workflow_state_was
|
||||
@points_possible_was = self.points_possible_was
|
||||
@muted_was = self.muted_was
|
||||
|
@ -923,7 +922,6 @@ class Assignment < ActiveRecord::Base
|
|||
group, students = group_students(original_student)
|
||||
opts[:unique_key] = Time.now.to_s
|
||||
opts[:author] ||= opts[:commenter] || opts[:user_id].present? && User.find_by_id(opts[:user_id])
|
||||
opts[:anonymous] = opts[:author] != original_student && self.anonymous_peer_reviews && !self.grants_right?(opts[:author], nil, :grade)
|
||||
|
||||
if opts[:comment] && opts[:assessment_request]
|
||||
# if there is no rubric the peer review is complete with just a comment
|
||||
|
|
|
@ -46,9 +46,6 @@ define([
|
|||
if($("#submission_comment_" + comment.id).length > 0) { continue; }
|
||||
var $comment = $("#comment_blank").clone(true).removeAttr('id');
|
||||
comment.posted_at = $.parseFromISO(comment.created_at).datetime_formatted;
|
||||
if(comment.anonymous) {
|
||||
comment.author_name = I18n.t("anonymous", "Anonymous");
|
||||
}
|
||||
$comment.fillTemplateData({
|
||||
data: comment,
|
||||
id: 'submission_comment_' + comment.id
|
||||
|
|
Loading…
Reference in New Issue