From 9bc33342d542183ec4e933855fe2213b0a93c2fb Mon Sep 17 00:00:00 2001 From: Clay Diffrient Date: Tue, 4 Nov 2014 11:18:40 -0700 Subject: [PATCH] a11y: Removes duplicate header from wiki pages Removes the SR-only header and replaces the h2 page title with an h1 page title (maintaining the same style) which keeps a duplicate header from being read by SR. fixes CNVS-16686 Test Plan: - Go to a wiki page - Screenreader should only have the page title header detected once, as a H1. Change-Id: Ie4f4bb1bd45b50ae62aeb91e4df50392c0e73cec Reviewed-on: https://gerrit.instructure.com/43854 Tested-by: Jenkins Reviewed-by: Dan Minkevitch QA-Review: Jahnavi Yetukuri Product-Review: Dan Minkevitch --- app/views/jst/wiki/WikiPage.handlebars | 2 +- app/views/wiki_pages/show_page.html.erb | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/views/jst/wiki/WikiPage.handlebars b/app/views/jst/wiki/WikiPage.handlebars index c8a409a04ff..0731bba61e9 100644 --- a/app/views/jst/wiki/WikiPage.handlebars +++ b/app/views/jst/wiki/WikiPage.handlebars @@ -67,7 +67,7 @@ {{/if}}
-

{{title}}

+

{{title}}

{{#if locked_for_user}}
{{#if lock_info.context_module.prerequisites}} diff --git a/app/views/wiki_pages/show_page.html.erb b/app/views/wiki_pages/show_page.html.erb index f79fb1d371f..7edb537a1a3 100644 --- a/app/views/wiki_pages/show_page.html.erb +++ b/app/views/wiki_pages/show_page.html.erb @@ -2,5 +2,4 @@ content_for :page_title, join_title(@page.title.to_s, @context.name) js_bundle :wiki_page_show %> -

<%= @page.title %>

\ No newline at end of file