Force by_role linter to give -1 and not -2

flag=none

Test Plan:
 - Add or modify a byRole query in a jest test
 - Commit and push
 * Verify linter leaves a -1, not a -2

Change-Id: I1722cdcab0d38f0f09de17b75fb2445d446cd78d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/349055
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Jacob DeWar <jacob.dewar@instructure.com>

gems/tatl_tael/lib/tatl_tael/linters/by_role_linter.rb

@@ -34,7 +34,8 @@ module TatlTael
           path:,
           message: config[:message],
           severity: config[:severity],
-          position:
+          position:,
+          ignore_boyscout_severity_change: true
         }
       end
 

gems/tatl_tael/spec/lib/tatl_tael/linters/by_role_linter_spec.rb

@@ -52,7 +52,8 @@ describe TatlTael::Linters::ByRoleLinter do
             path: file,
             message: config[:message],
             severity: config[:severity],
-            position: line_number
+            position: line_number,
+            ignore_boyscout_severity_change: true
           }
         end
       end.flatten
@@ -100,7 +101,8 @@ describe TatlTael::Linters::ByRoleLinter do
               path: file,
               message: config[:message],
               severity: config[:severity],
-              position: line_number
+              position: line_number,
+              ignore_boyscout_severity_change: true
             }
           end
         end.flatten
@@ -141,7 +143,8 @@ describe TatlTael::Linters::ByRoleLinter do
               path: file,
               message: config[:message],
               severity: config[:severity],
-              position: line_number
+              position: line_number,
+              ignore_boyscout_severity_change: true
             }
           end
         end.flatten
@@ -168,7 +171,8 @@ describe TatlTael::Linters::ByRoleLinter do
               path: file,
               message: config[:message],
               severity: config[:severity],
-              position: line_number
+              position: line_number,
+              ignore_boyscout_severity_change: true
             }
           end
         end.flatten

script/linter.rb

@@ -150,7 +150,7 @@ class Linter
     if gerrit_patchset
       if boyscout_mode
         processed_comments.each do |comment|
-          comment[:severity] = "error"
+          comment[:severity] = "error" unless comment[:ignore_boyscout_severity_change]
         end
       end
       publish_gergich_comments(processed_comments)