ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix scrollbar issues in Gradebook 

Test plan:
  - Create course with 50 students and 10 assignments
  - In Gradebook, use both scrollbars
  - Neither should interfere with content

Fixes EVAL-4172

Change-Id: I8cbefc111770b27e177e731e1987bcad3f2f6ec4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/347826
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This commit is contained in:
Aaron Shafovaloff 2024-05-20 12:38:47 -06:00
parent c3a5771141
commit 989cb0fe0c
2 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/stylesheets/pages/gradebook/_gradebook.scss
View File

@ -1102,18 +1102,4 @@ $gradebook_checkbox_size: 16px;
// Specific width to ensure the text of the dialog doesn't wrap by default
#anonymous-speed-grader-alert-container {
min-width: 35rem;
}
.slick-viewport::-webkit-scrollbar {
height: 3px;
width: 3px;
}
.slick-viewport::-webkit-scrollbar-track {
background: #f1f1f1;
}
.slick-viewport::-webkit-scrollbar-thumb {
background-color: darkgrey;
border-radius: 10px;
}

2
packages/slickgrid/slick.grid.js vendored
View File

@ -2187,7 +2187,7 @@ if (typeof Slick === 'undefined') {
return
}
numberOfRows =
getDataLengthIncludingAddNew() + (options.leaveSpaceForNewRows ? numVisibleRows - 1 : 0)
getDataLengthIncludingAddNew() + (options.leaveSpaceForNewRows ? numVisibleRows - 1 : 0) + 1
var oldViewportHasVScroll = viewportHasVScroll_1
// with autoHeight, we do not need to accommodate the vertical scroll bar