ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spec: fix fragile calendar specs 

added expect to force chrome to wait for popup to flash
added popup to css search to specifically find the button on the popup

Test Plan:
- Pass Jenkins
- Code review

Change-Id: I1f8c8ded35261b3af209ff3b2ab6545d99017160
Reviewed-on: https://gerrit.instructure.com/112305
Tested-by: Jenkins
Reviewed-by: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
This commit is contained in:
Robert Lamb 2017-05-18 12:32:52 -06:00
parent c976674b0c
commit 9117e20a05
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
spec/selenium/calendar/calendar2_scheduler_student_spec.rb
View File

@ -226,22 +226,26 @@ describe "scheduler" do
load_month_view
f('.fc-event.scheduler-event').click
f('.unreserve_event_link').click
f('#delete_event_dialog~.ui-dialog-buttonpane .btn-primary').click
# in Chrome, the event-detail popop flashes and changes size
# the expect and explicit search seems to make the spec less fragile
expect(f('.event-details .unreserve_event_link')).to be_displayed
f('.event-details .unreserve_event_link').click
wait_for_ajaximations
f('#delete_event_dialog~.ui-dialog-buttonpane .btn-primary').click
expect(f("#content")).not_to contain_css('.fc-event.scheduler-event')
end
it "should let me do so from the week view", priority: "1", test_id: 502483 do
load_week_view
f('.fc-event.scheduler-event').click
f('.unreserve_event_link').click
f('#delete_event_dialog~.ui-dialog-buttonpane .btn-primary').click
# in Chrome, the event-detail popop flashes and changes size
# the expect and explicit search seems to make the spec less fragile
expect(f('.event-details .unreserve_event_link')).to be_displayed
f('.event-details .unreserve_event_link').click
wait_for_ajaximations
f('#delete_event_dialog~.ui-dialog-buttonpane .btn-primary').click
expect(f("#content")).not_to contain_css('.fc-event.scheduler-event')
end
@ -250,8 +254,11 @@ describe "scheduler" do
load_agenda_view
f('.agenda-event__item-container').click
# in Chrome, the event-detail popop flashes and changes size
# the expect and explicit search seems to make the spec less fragile
expect(f('.event-details .unreserve_event_link')).to be_displayed
f('.event-details .unreserve_event_link').click
wait_for_ajaximations
f('.unreserve_event_link').click
f('#delete_event_dialog~.ui-dialog-buttonpane .btn-primary').click
expect(f("#content")).not_to contain_css('.agenda-event__item-container')