ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

accessiblity touch ups when copying a course 

fixes CNVS-12188

When you are migrating a course and using voice over in safari it was
really confusing because when you selected 'copy course' and did a
course search or a course select, the results would be read we everything else on the
page. This fixes that.

Test Plan
As a teacher or someone who can run a migration
Given you are using safari with voice over
When you import content into a course
And you select the content type of 'Copy a Canvas Course'
And you search for a course by its name by using the field
Then voice over should tell you there are results
And when you use the arrow keys to select one of those results
Then only the selected result should be read by voice over
And the all of the form items should not be read
----------------------------------------------------
As a teacher or someone who can run a migration
Given you are using safari with voice over
When you import content into a course
And you select the content type of 'Copy a Canvas Course'
And you select a course in the course select dropdown
And when you use the arrow keys to select one of those results
Then only the selected result should be read by voice over
And the all of the form items should not be read

Change-Id: Id2c265d900ee9676094e221fa9dd38e8a61a843a
Reviewed-on: https://gerrit.instructure.com/35240
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
This commit is contained in:
Sterling Cobb 2014-05-21 09:29:58 -06:00
parent 28eb7d9e60
commit 8eaa70f8d9
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/coffeescripts/views/content_migrations/subviews/CourseFindSelectView.coffee
View File

@ -35,6 +35,15 @@ define [
@$courseSearchField.data('ui-autocomplete')._renderItem = (ul, item) ->
$(autocompleteItemTemplate(item)).appendTo(ul)
# Accessiblity Hack. If you find a better solution please fix this. This makes it so the whole form isn't read
# by the screen reader every time a user selects an auto completed item.
$converterDiv = $('#converter')
@$courseSearchField.on 'focus', -> $converterDiv.attr('aria-atomic', false)
@$courseSearchField.on 'blur', -> $converterDiv.attr('aria-atomic', true)
@$courseSelect.on 'focus', -> $converterDiv.attr('aria-atomic', false)
@$courseSelect.on 'blur', -> $converterDiv.attr('aria-atomic', true)
## hack finished ##
toJSON: ->
json = super
json.terms = @coursesByTerms