use excused instead of excused? for AR-agnosticism

and document the dependency

refs CNVS-21654

Change-Id: I40056afb93cb1c1968cf5019d613d662b1aa9ad6
test-plan: N/A
Reviewed-on: https://gerrit.instructure.com/61804
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
This commit is contained in:
Jacob Fugal 2015-08-25 15:52:54 -06:00
parent 3b24d18e08
commit 8bdf173cb1
1 changed files with 2 additions and 1 deletions

View File

@ -1058,6 +1058,7 @@ class Submission < ActiveRecord::Base
# * cached_due_date (Time)
# * submitted_at (Time)
# * score (Fixnum)
# * excused (Boolean)
#
module Tardiness
def past_due?
@ -1087,7 +1088,7 @@ class Submission < ActiveRecord::Base
# QUESTIONS FOR ME:
# * are we messing up graded / not graded counts???
def graded?
excused? || (!!score && workflow_state == 'graded')
excused || (!!score && workflow_state == 'graded')
end
end
include Tardiness