From 8ba9047dbc7002562dd0fb753d6dcb264fe194a7 Mon Sep 17 00:00:00 2001 From: Ryan Shaw Date: Wed, 29 Aug 2018 16:30:34 -0600 Subject: [PATCH] =?UTF-8?q?don=E2=80=99t=20load=20section-tab=20info=20on?= =?UTF-8?q?=20planner=20dashboard?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: CORE-1789 Nothing in the planner actually uses this info. So we can avoid doing all the work to decide to show what tabs are available to this person by not including this. It is a big win because right now, there is no limit to the number of courses we pass through this since @current_user.courses_with_primary_enrollment is limitless. There is another commit coming that will also make the dashcards, which do need this info, faster but at least there is a maximum of 20 courses that runs against. This will drastically help the load that was caused by turning on the Student planner feature flag Test plan: * load the student planner dashboard * it should be a lot faster and there should not be anything you missed out on Change-Id: I5cd52cef95501d4ce607bf241060f0bf502260d2 Reviewed-on: https://gerrit.instructure.com/162640 Tested-by: Jenkins Reviewed-by: Rob Orton Reviewed-by: Mysti Sadler Reviewed-by: Cody Cutrer Reviewed-by: Jeremy Stanley Product-Review: Ryan Shaw QA-Review: Ryan Shaw --- app/controllers/users_controller.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index daceae4e469..a41d38f51aa 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -536,8 +536,7 @@ class UsersController < ApplicationController :custom_colors => @current_user.custom_colors, }, :STUDENT_PLANNER_ENABLED => planner_enabled?, - :STUDENT_PLANNER_COURSES => planner_enabled? && map_courses_for_menu(@current_user.courses_with_primary_enrollment, - :include_section_tabs => true), + :STUDENT_PLANNER_COURSES => planner_enabled? && map_courses_for_menu(@current_user.courses_with_primary_enrollment), :STUDENT_PLANNER_GROUPS => planner_enabled? && map_groups_for_planner(@current_user.current_groups) })