ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update manage_students label and description for granular split 

refs FOO-1641
flag = granular_permissions_manage_users

test plan: label and descrption for manage_students are updated when the
granular_permissions_manage_users flag is enabled.

Change-Id: Ibd0b5d746b39a41a74590f47945c1de5eb3421a1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260382
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
This commit is contained in:
Simon Williams 2021-03-10 14:29:52 -06:00
parent 16b1a67f8e
commit 8b4066e994
2 changed files with 111 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

104
app/jsx/permissions/templates.js
View File

@ -2932,27 +2932,117 @@ const pairingCodePermissions = generateActionTemplates(
]
)
const courseAddRemovePermissions = generateActionTemplates(
// Old description when flag is off
let courseAddRemovePermissions = generateActionTemplates(
'manage_students',
[
{
title: I18n.t('Deprecated'),
title: I18n.t('Courses (Account)'),
description: I18n.t('Allows user to add students to a course from the account Courses page.')
},
{
title: I18n.t('People (Course)'),
description: I18n.t(
'This permission is deprecated. Please reference Users - Students and Users - Observers.'
'Allows user to add and remove students. Allows user to add and remove observers. Allows user to view login ID information for students. Allows user to view prior enrollments. Allows user to access a user’s settings menu and user details. Allows user to edit a student’s section or role. Allows user to resend course invitations from the Course People page.'
)
}
],
[],
[
{
title: I18n.t('Deprecated'),
title: I18n.t('Account Settings'),
description: I18n.t(
`This permission is deprecated. Please reference Users - Students and Users - Observers.`
'If the Open Registration account setting is enabled, users with this permission can add students or observers to a course via email address or login ID even if the student or observer does not already have a Canvas account.'
)
},
{
title: I18n.t('Courses (Account)'),
description: I18n.t(
'To access the account Courses page, Courses - view list must be enabled.'
)
},
{
title: I18n.t('People (Course)'),
description: I18n.t(
`Enrollments may be added by your institution student information system (SIS). If an enrollment is created via SIS, only admins can remove the enrollment from the course.
To view the list of users in the course, Users - view list must be enabled. To view SIS IDs, SIS Data - read must be enabled. To add a user to a course via SIS ID, SIS Data - manage must also be enabled. To edit a student's section and course role, Users - view list and Conversations - send messages to individual course members must also be enabled. To unenroll users the user details page, View the list of courses and See the list of users must also be enabled. Allows user to resend course invitations from the Course People page. If the Open Registration account setting is enabled, users with this permission can add students to a course from the Course People page via email addresses if the user does not already have a Canvas account. To link an observer to a student, Users - manage login details and Conversations - send to individual course members must be enabled.`
)
}
],
[]
[
{
title: I18n.t('People'),
description: I18n.t(
`Allows user to add and remove students to the course. Allows user to add and remove observers to the course. Allows user to view login ID information for students. Allows user to view prior enrollments. Allows user to access a user’s settings menu and user details. Allows user to conclude or delete enrollments on a student’s details page. Allows user to resend course invitations.`
)
}
],
[
{
title: I18n.t('People'),
description: I18n.t(
`Enrollments may be added by your institution student information system (SIS). If an enrollment is created via SIS, only admins can remove the enrollment from the course.
To access the People Page, Users - view list must be enabled. If the Open Registration account setting is enabled, users with this permission can add students to a course via email address if the user does not already have a Canvas account. To view SIS IDs, SIS Data - read must be enabled. To add a user to a course via SIS ID, SIS Data - manage must also be enabled. To edit a student’s section, Users - view list and Conversations - send messages to individual course members must also be enabled. To link an observer to a student, Conversations - send messages to individual course members must also be enabled.`
)
}
]
)
if (ENV.FEATURES && ENV.FEATURES.granular_permissions_manage_users) {
courseAddRemovePermissions = generateActionTemplates(
'manage_students',
[
{
title: I18n.t('People (Course)'),
description: I18n.t(
'Allows user to view login ID information for students. Allows user to view prior enrollments. Allows user to access a user’s settings menu and user details. Allows user to edit a student’s section or role. Allows user to resend course invitations from the Course People page.'
)
}
],
[
{
title: I18n.t('Account Settings'),
description: I18n.t(
'If the Open Registration account setting is enabled, users with this permission can add students or observers to a course via email address or login ID even if the student or observer does not already have a Canvas account.'
)
},
{
title: I18n.t('Courses (Account)'),
description: I18n.t(
`To access the account Courses page, Courses - view list must be enabled.`
)
},
{
title: I18n.t('People (Course)'),
description: I18n.t(
`To view the list of users in the course, Users - view list must be enabled.
To view SIS IDs, SIS Data - read must be enabled. To add a user to a course via SIS ID, SIS Data - manage must also be enabled.
To edit a student’s section, Conversations - send to individual course members must also be enabled.
To unenroll users from the user details page, Courses - view list and Users - view list must also be enabled.
To link an observer to a student, Users - manage login details and Conversations - send to individual course members must be enabled.`
)
}
],
[
{
title: I18n.t('People (Course)'),
description: I18n.t(
'Allows user to view login ID information for students. Allows user to view prior enrollments. Allows user to access a user’s settings menu and user details. Allows user to edit a student’s section or role. Allows user to resend course invitations from the Course People page.'
)
}
],
[
{
title: I18n.t('People (Course)'),
description: I18n.t(
`To view the list of users in the course, Users - view list must be enabled.
To view SIS IDs, SIS Data - read must be enabled. To add a user to a course via SIS ID, SIS Data - manage must also be enabled.
To edit a student’s section, Conversations - send to individual course members must also be enabled.
To unenroll users from the user details page, Courses - view list and Users - view list must also be enabled.
To link an observer to a student, Users - manage login details and Conversations - send to individual course members must be enabled.`
)
}
]
)
}
const usersViewListPermissions = generateActionTemplates(
'read_roster',

16
app/models/role_override.rb
View File

@ -931,8 +931,20 @@ class RoleOverride < ActiveRecord::Base
true_for: %w[AccountAdmin TeacherEnrollment DesignerEnrollment]
},
:manage_students => {
:label => lambda { t('permissions.manage_students', "Add/remove students for the course") },
:label_v2 => lambda { t("Users - add / remove students in courses") },
:label => lambda {
if Account.site_admin.feature_enabled?(:granular_permissions_manage_users)
t("Manage students for the course")
else
t('permissions.manage_students', "Add/remove students for the course")
end
},
:label_v2 => lambda {
if Account.site_admin.feature_enabled?(:granular_permissions_manage_users)
t("Users - manage students in courses")
else
t("Users - add / remove students in courses")
end
},
:available_to => [
'TaEnrollment',
'DesignerEnrollment',