ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

improve a11y for course image selector button 

test plan:
 - enable the dashboard card images feature
 - choose a course card image for a course
 - return to the course settings page
 - the kebab menu button for the course should have
   hover text that reads "Course image settings"
 - the kebab menu button should also be read as
   "Course image settings" by screenreaders including JAWS

fixes ADMIN-2739

Change-Id: I3b9c2e8515f712c3d67da49ab17071c2237afdb4
Reviewed-on: https://gerrit.instructure.com/198935
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
This commit is contained in:
Jeremy Stanley 2019-06-25 10:36:38 -06:00
parent 86a7d18829
commit 8af5294859
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/jsx/course_settings/components/CourseImageSelector.js
View File

@ -71,8 +71,8 @@ export default class CourseImageSelector extends React.Component {
<Menu
trigger={
<div className="CourseImageSelector__Button">
<Button size="small" variant="circle-primary">
<IconMoreLine title={I18n.t('Course image settings')} />
<Button size="small" variant="circle-primary" title={I18n.t('Course image settings')} aria-label={I18n.t('Course image settings')}>
<IconMoreLine/>
</Button>
</div>
}