rename intro_message and make it more general

The function intro_message is a general function and should
not print a particular message when invoked, also it has been rename
to better represent what the function is actually doing.

refs DE-470
flag = none

test-plan:
- docker_dev_update runs successfully
- canvs_update runs successfully

Change-Id: I6f49eb756ff4bb2549f900ada7bdf05bcbf1345b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262436
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>

script/canvas_update

@@ -24,7 +24,8 @@ function tips {
 
 function update_canvas {
   ensure_in_canvas_root_directory
-  intro_message "Canvas Update"
+  message "Bringing Canvas up to date ..."
+  init_log_file "Canvas Update"
 
   if [[ -z "$SKIP_CODE" ]] ; then
     ./script/rebase_canvas_and_plugins.sh

script/common/utils/common.sh

@@ -44,9 +44,8 @@ function is_git_dir {
 }
 
 # Parameter: the name of the script calling this function
-function intro_message {
+function init_log_file {
   script_name="$1"
-  echo "Bringing Canvas up to date ..."
   echo "  Log file is $LOG"
 
   echo >>"$LOG"

script/docker_dev_update.sh

@@ -88,7 +88,8 @@ fi
 echo ""
 
 create_log_file
-intro_message "Docker Dev Update"
+message "Bringing Canvas up to date ..."
+init_log_file "Docker Dev Update"
 [[ -n "$UPDATE_CODE" ]] && ./script/rebase_canvas_and_plugins.sh "${params[@]}"
 bundle_install_with_check
 install_node_packages

script/rebase_canvas_and_plugins.sh

@@ -159,7 +159,7 @@ function print_results {
 
 ensure_in_canvas_root_directory
 create_log_file
-intro_message "Rebase Canvas and Plugins"
+init_log_file "Rebase Canvas and Plugins"
 check_for_changes
 [[ -n "$SKIP_CANVAS" ]] || rebase_canvas
 [[ -n "$SKIP_PLUGINS" ]] || rebase_plugins