ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

include :filter_speed_grader_by_student_group in course settings converter 

fixes FOO-2934
flag = none

Test plan:
• Enable the following root account features:
   • :course_templates
   • :filter_speed_grader_by_student_group
• Create a course and check the following boxes in the course
  settings:
   • Enable course as course template
   • Launch SpeedGrader Filtered by Student Group
• Create a sub-account, in the account settings designate the
  course as the “Course Template” and save your changes
• In that sub-account, create a new course and wait for the
  template import to finish
• Once done, check the course settings and note that
  “Launch SpeedGrader Filtered by Student Group” *is* checked

Change-Id: I41265f1dbc076a2895a8100f2202353276da9dc3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/295797
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
This commit is contained in:
August Thornton 2022-07-08 14:50:06 -06:00
parent c338c867f9
commit 7cb84dbb91
2 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/cc/importer/canvas/course_settings.rb
View File

@ -71,12 +71,11 @@ module CC::Importer::Canvas
end
%w[is_public is_public_to_auth_users
public_syllabus public_syllabus_to_auth syllabus_course_summary
indexed allow_student_wiki_edits
allow_student_assignment_edits show_public_context_messages
allow_student_forum_attachments allow_student_organized_groups lock_all_announcements
open_enrollment allow_wiki_comments
self_enrollment hide_final_grade grading_standard_enabled
hide_distribution_graphs allow_student_discussion_topics
indexed allow_student_wiki_edits allow_student_assignment_edits
show_public_context_messages allow_student_forum_attachments
allow_student_organized_groups lock_all_announcements open_enrollment allow_wiki_comments
self_enrollment hide_final_grade filter_speed_grader_by_student_group
grading_standard_enabled hide_distribution_graphs allow_student_discussion_topics
allow_student_discussion_editing show_announcements_on_home_page usage_rights_required
restrict_student_future_view restrict_student_past_view show_total_grade_as_points
organize_epub_by_content_type enable_offline_web_export restrict_enrollments_to_course_dates

9
spec/apis/v1/courses_api_spec.rb
View File

@ -1251,10 +1251,16 @@ describe CoursesController, type: :request do
end
it "applies a course template" do
template = @account.courses.create!(name: "Template", template: true)
settings_hash = { filter_speed_grader_by_student_group: true }
template = @account.courses.create!(
name: "Template",
settings: settings_hash,
template: true
)
template.assignments.create!(title: "my assignment")
@account.root_account.enable_feature!(:course_templates)
@account.root_account.enable_feature!(:filter_speed_grader_by_student_group)
@account.update!(course_template: template)
post_params = {
@ -1271,6 +1277,7 @@ describe CoursesController, type: :request do
expect(new_course.name).to eq "Test Course"
expect(new_course.assignments.length).to eq 1
expect(new_course.assignments.first.title).to eq "my assignment"
expect(new_course.settings[:filter_speed_grader_by_student_group]).to be true
end
it "removes start and end dates when restrict_enrollments_to_course_dates is false and an enrollment_term is present" do