clarify why we gulp rev a raw version of jquery
Closes: CORE-15 Test plan: * Add a custom JS file to your account in theme editor (e.g.: something like `console.log(‘this is jquery’, $)`) * Log out * Go to login screen from a mobile device (or you can cheat with http://localhost:3000/login/canvas?mobile=true) * make sure that your custom js gets loaded and that jquery does too Change-Id: I229609a353bc14db97318ef708dbfb46ca18113c Reviewed-on: https://gerrit.instructure.com/131374 Tested-by: Jenkins Reviewed-by: Clay Diffrient <cdiffrient@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com> QA-Review: Ryan Shaw <ryan@instructure.com>
This commit is contained in:
parent
e78cad8ebb
commit
7b3dda4e55
|
@ -40,7 +40,7 @@ gulp.task('rev', () => {
|
|||
const timezonesStream = gulp
|
||||
.src(timezoneFileGlobs, {base: './node_modules'})
|
||||
.pipe(gulpTimezonePlugin())
|
||||
|
||||
|
||||
const customTimezoneStream = gulp
|
||||
.src('./public/javascripts/custom_timezone_locales/*.js')
|
||||
.pipe(rename(path => path.dirname = '/timezone'))
|
||||
|
@ -67,8 +67,11 @@ gulp.task('rev', () => {
|
|||
follow: true // follow symlinks, so it picks up on images inside plugins and stuff
|
||||
}),
|
||||
gulp.src([
|
||||
// this is used by the include_account_js call in mobile_auth.html.erb to make sure '$' is there for accounts' custom js files
|
||||
// on the mobile login screen, we don't load any of our webpack js bundles. but if they
|
||||
// have a custom js file, we do load a raw copy of jquery for their custom js to use.
|
||||
// See `include_account_js` in mobile_auth.html.erb
|
||||
'node_modules/jquery/jquery.js',
|
||||
|
||||
'node_modules/tinymce/skins/lightgray/**/*',
|
||||
], {
|
||||
base: '.'
|
||||
|
|
Loading…
Reference in New Issue