ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spec: ignore intermittent console errors 

refs DE-186

[fsc-propagate=false]

Bypassing FSC because this spec sets a cookie that tells the flash alert to only appear once. The spec was manually run 30 times locally without failure.

for n in {1..30}; do docker-compose run --rm web bundle exec rspec spec/selenium/flash_notifications_spec.rb; done

Change-Id: Ic52c4482b862ec0312b206d3d08b5a75b54bebc9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244688
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
This commit is contained in:
Aaron Ogata 2020-08-10 14:08:45 -07:00
parent 2cd95484f0
commit 743584aeb5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/selenium/flash_notifications_spec.rb
View File

@ -20,7 +20,8 @@ require_relative 'common'
describe "flash notifications" do
include_context "in-process server selenium tests"
it "should show unsupported browser message but allow you to dismiss it" do
it "should show unsupported browser message but allow you to dismiss it", ignore_js_errors: true do
# fix console errors in DE-186 (8/10/2020)
allow_any_instance_of(ApplicationController).to receive(:browser_supported?).and_return(false)
get "/login"
expect(f(flash_message_selector)).to include_text "Your browser does not meet the minimum requirements for Canvas"