ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix remove student from appt. group button 

this gets it working in JAWS, though you still cannot arrow your way to
the remove student button in NVDA. I believe this is a bug in the screen
reader and this is the best we can do

test plan:
  - recreate steps from the ticket
  > using JAWS, you can down-arrow into the X button and press it
  > using NVDA, you can down-arrow into the student's name and the SR
    will read it, but you have to TAB into the button to press it

fixes CNVS-35823

Change-Id: Ida4a9ee2326eb56615b8ccc877dbde5d93dc1fa0
Reviewed-on: https://gerrit.instructure.com/106337
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Jenkins
This commit is contained in:
Ed Schiebel 2017-03-24 16:38:10 -04:00
parent 55435653dd
commit 6f48ef13e0
2 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/stylesheets/base/mixins/_bubbles.scss
View File

@ -10,11 +10,15 @@
vertical-align: middle;
display: inline-block;
}
a {
a, button {
color: $ic-font-color-dark;
padding-right: $contentBoxPadding;
cursor: pointer;
vertical-align: middle;
background-color: transparent;
border: 1px solid transparent;
&:hover {
border: 1px solid $ic-font-color-dark;
}
}
white-space: nowrap;
float: left;

6
app/views/jst/calendar/eventDetails.handlebars
View File

@ -11,7 +11,7 @@
</div>
<div class="event-details-content">
<div class="event-details-timestring">{{{displayTimeString}}}</div>
<table cellspacing="0">
<table cellspacing="0" role="presentation">
{{#if contextInfo}}
<tr>
<th scope="row">{{#t "calendar"}}Calendar{{/t}}</th>
@ -57,10 +57,10 @@
{{#each reservations}}
<li data-url="{{event_url}}">
<div class="ellipsis">{{name}}</div>
<a href="javascript:void(0)" class="cancel_appointment_link" title="{{#t}}Remove attendee {{name}}{{/t}}">
<button type="button" class="cancel_appointment_link" title="{{#t}}Remove attendee {{name}}{{/t}}">
<i class="icon-x" aria-hidden="true"></i>
<span class="screenreader-only">{{#t}}Remove attendee {{name}}{{/t}}</span>
</a>
</button>
</li>
{{/each}}
</ul>