ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove extra return check on error state 

the next line checks that workflow_state is running and returns false if
it is anything besides running.

Change-Id: I38d9015b7e0ab8908d5e7b8ea957d69f0feff024
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/248864
Reviewed-by: Mark Valentine <mvalentine@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
This commit is contained in:
Rob Orton 2020-09-29 12:29:12 -06:00
parent eed894608d
commit 6931030d92
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gems/plugins/account_reports/lib/account_reports/report_helper.rb
View File

@ -466,7 +466,6 @@ module AccountReports::ReportHelper
return false if account_report.account_report_runners.incomplete.exists?
AccountReport.transaction do
@account_report.reload(lock: true)
return false if account_report.workflow_state == 'error'
if @account_report.workflow_state == 'running'
@account_report.workflow_state = 'compiling'
@account_report.save!