ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

trigger tsc check on .js and package changes 

Change-Id: I016613970dfa6644fabb6d38249ed25070c764bd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316273
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
This commit is contained in:
Aaron Shafovaloff 2023-04-18 11:08:05 -06:00
parent 1e6c3e5b6e
commit 67de1c8fb5
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hooks/pre-commit
View File

@ -12,7 +12,7 @@ CANVAS=$(dirname $SCRIPTPATH)
if [ $(pwd -P) = $CANVAS ]; then
# if .ts or .tsx files have changed (excluding those in packages/), run tsc
if git diff --cached --name-only | grep -vE '^packages/' | grep -qE '\.(ts|tsx)$'; then
if git diff --cached --name-only | grep -qE '\.(ts|tsx|js)$'; then
if [ -f node_modules/.bin/tsc ]; then
echo 'Checking TypeScript...'
NODE_OPTIONS=--max-old-space-size=4096 node_modules/.bin/tsc -p tsconfig.json

3
ui/features/gradebook/react/default_gradebook/Gradebook.tsx
View File

@ -107,7 +107,6 @@ import type {ProxyDetails} from '@canvas/proxy-submission/react/ProxyUploadModal
import type TotalGradeColumnHeader from './GradebookGrid/headers/TotalGradeColumnHeader'
import type {SendMessageArgs} from '@canvas/message-students-dialog/react/MessageStudentsWhoDialog'
// @ts-expect-error
import KeyboardNavDialog from '@canvas/keyboard-nav-dialog'
// @ts-expect-error
import KeyboardNavTemplate from '@canvas/keyboard-nav-dialog/jst/KeyboardNavDialog.handlebars'
@ -325,7 +324,7 @@ type GradebookState = {
}
class Gradebook extends React.Component<GradebookProps, GradebookState> {
kbDialog: KeyboardNavDialog
kbDialog: any
anonymousSpeedGraderAlert?: any