ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make it possible for KO users to use the conversations modal 

fixes COMMS-2029

Test Plan
* On the Compose page, click on the Compose
New Message button in the top right (pencil on paper)
* Press Tab to move focus to the Course combo box
* Press Shift+Tab
* Press Tab
* Press Tab
* Press Shift+Tab
* Focus actually allows for navigation now

Change-Id: I1359960f847514e8f6c0b89da8c9ebb65bedd262
Reviewed-on: https://gerrit.instructure.com/192636
Reviewed-by: Michelle Simmons <misimmons@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
Product-Review: Aaron Hsu <ahsu@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
This commit is contained in:
Aaron Hsu 2019-05-08 11:26:27 -06:00
parent f3b69ab2c4
commit 65f2ebcb81
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/javascripts/vendor/jqueryui/dialog-unpatched.js vendored
View File

@ -337,7 +337,7 @@ $.widget("ui.dialog", {
// Safari was shift-tabbing from a control in the
// middle of the new conversations compose dialog
// to a background control, killing focus
var tabbables = $( ":tabbable, input[role='combobox']", this.uiDialog );
var tabbables = $( ":tabbable", this.uiDialog );
var index = $.inArray( event.target, tabbables );
if ( index == -1 ) {return;}
var targetIndex = index + (event.shiftKey ? -1 : 1);