ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change attachment icon to paper clip in modules 

fixes: UIDEV-154

Test plan:
- Go to a Module in Canvas and add a file to it
- The modal window where you select a resource type to
  add to the Module should now show a paperclip icon
  when you select `File`
- The attached file should now be represented by
  a paperclip icon on the left side of the Module's
  item group

Change-Id: I32c9d0b29742fec078ab3cb0b3ca58b2d1a2c8fc
Reviewed-on: https://gerrit.instructure.com/137157
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
This commit is contained in:
Chris Hart 2018-01-08 11:12:12 -05:00
parent 6a5268f9f8
commit 62f4c48178
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/coffeescripts/jquery/ModuleSequenceFooter.js vendored
View File

@ -90,7 +90,7 @@ export default class ModuleSequenceFooter {
iconClasses = { iconClasses = {
ModuleItem: 'icon-module', ModuleItem: 'icon-module',
File: 'icon-download', File: 'icon-paperclip',
Page: 'icon-document', Page: 'icon-document',
Discussion: 'icon-discussion', Discussion: 'icon-discussion',
Assignment: 'icon-assignment', Assignment: 'icon-assignment',

4
app/coffeescripts/views/modules/ProgressionModuleView.coffee
View File

@ -36,7 +36,7 @@ define [
iconClasses: iconClasses:
'ModuleItem' : "icon-module" 'ModuleItem' : "icon-module"
'File' : "icon-download" 'File' : "icon-paperclip"
'Page' : "icon-document" 'Page' : "icon-document"
'Discussion' : "icon-discussion" 'Discussion' : "icon-discussion"
'Assignment' : "icon-assignment" 'Assignment' : "icon-assignment"
@ -56,4 +56,4 @@ define [
afterRender: -> afterRender: ->
super super
@model.collection.syncHeight() @model.collection.syncHeight()

2
app/stylesheets/components/_g_context_modules.scss
View File

@ -335,7 +335,7 @@ $context_module_bg_color: #f2f3f4;
.icon-document { .icon-document {
display: none; display: none;
} }
.icon-download { .icon-paperclip {
display: inline-block; display: inline-block;
} }
} }

2
app/views/context_modules/_module_item_next.html.erb
View File

@ -79,7 +79,7 @@
<span class="type_icon" title="<%= module_item_translated_content_type(module_item) %>"> <span class="type_icon" title="<%= module_item_translated_content_type(module_item) %>">
<span class="ig-type-icon"> <span class="ig-type-icon">
<i class="icon-document" aria-label="<%= t('Item type: Document') %>"></i> <i class="icon-document" aria-label="<%= t('Item type: Document') %>"></i>
<i class="icon-download" aria-label="<%= t('Item type: Download') %>"></i> <i class="icon-paperclip" aria-label="<%= t('Item type: Download') %>"></i>
<i class="icon-discussion" aria-label="<%= t('Item type: Discussion') %>"></i> <i class="icon-discussion" aria-label="<%= t('Item type: Discussion') %>"></i>
<i class="icon-assignment" aria-label="<%= t('Item type: Assignment') %>"></i> <i class="icon-assignment" aria-label="<%= t('Item type: Assignment') %>"></i>
<i class="icon-quiz" aria-label="<%= t('Item type: Quiz') %>"></i> <i class="icon-quiz" aria-label="<%= t('Item type: Quiz') %>"></i>

2
app/views/shared/_select_content_dialog.html.erb
View File

@ -165,7 +165,7 @@
<% if !only || only.include?(:attachments) %> <% if !only || only.include?(:attachments) %>
<div id="attachments_select" class="module_item_option"> <div id="attachments_select" class="module_item_option">
<div style="font-size: 0.8em;" id="file_select_label"> <div style="font-size: 0.8em;" id="file_select_label">
<i class="icon-download"></i> <i class="icon-paperclip" aria-hidden="true"></i>
<%= t :file_notice, 'Select the file you want to associate with this *module*, or add a file by selecting "New File".', :wrapper => '<span class="holder_type">\1</span>' %> <%= t :file_notice, 'Select the file you want to associate with this *module*, or add a file by selecting "New File".', :wrapper => '<span class="holder_type">\1</span>' %>
</div> </div>
<div style="margin-top: 5px;"> <div style="margin-top: 5px;">