ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dont force valid email address on mobile login, fixes: #CNVS-2306 

test plan:
on an android in the mobile chrome browser go to log into canvas
try to log in with a non-email username (for example, mine is 'ryan')
make sure it lets you log in.

right now it errors because we add "type=email" to
the input to get the nice email-hinted keyboard entry.
but by doing so, it will also use native validatation
to make sure it is a valid email, adding "novalidate"
to the <form> fixes it

Change-Id: Ie3215100d07a932508c366dac147d59502696c8e
Reviewed-on: https://gerrit.instructure.com/16175
QA-Review: Mark Suman <marks@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
This commit is contained in:
Ryan Shaw 2012-12-18 13:13:47 -07:00 committed by Mark Suman
parent 16bc449325
commit 61259ca30d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/pseudonym_sessions/mobile_login.html.erb
View File

@ -128,7 +128,7 @@
<body>
<div id="f1_container">
<div id="f1_card">
<% form_for :pseudonym_session, :url => login_path, :html => {:id => "login_form", :class => "front face"} do |f| %>
<% form_for :pseudonym_session, :url => login_path, :html => {:id => "login_form", :class => "front face", :novalidate => 'novalidate'} do |f| %>
<input <%= 'type=email' if @login_handle_is_email %> name="pseudonym_session[unique_id]" value="<%= params[:pseudonym_session].try(:[], :unique_id) %>" placeholder="<%= @login_handle_name %>">
<input type="password" name="pseudonym_session[password]" placeholder="<%= t :password, "Password" %>">
<button type="submit"><%= t('login', 'Login') %></button>