ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clarify button descriptions on manage discussion topic links. 

fixes #9193

previously, the "gear" links on the discussion page read "manage."
they now read, "manage discussion," and "manage discussion entry"
respectively.

test plan:
  * using voiceover or another screen reader, navigate to
    the discussions page and tab to the gear link at the top
    of the discussion and at the top of a response;
  * verify that the screen reader reads, "manage discussion" and
    "manage discussion entry" on the appropriate links.

Change-Id: Ie2de22f09c86340c2cdc551fa32b72ee53beaafa
Reviewed-on: https://gerrit.instructure.com/13443
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
This commit is contained in:
Zach Pendleton 2012-09-04 16:26:16 -06:00
parent f3be56192b
commit 5744ac4e5c
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/discussion_topics/show.html.erb
View File

@ -62,7 +62,7 @@
<div class="discussion-header-content right-of-avatar">
<% if can_do(@topic, @current_user, :update) || can_do(@topic, @current_user, :delete) %>
<div class="admin-links">
<button class="al-trigger ui-button" data-kyle-menu-options='{"appendMenuTo": "body"}'><span class="al-trigger-inner"><%= t :manage, 'Manage' %></span></button>
<button class="al-trigger ui-button" data-kyle-menu-options='{"appendMenuTo": "body"}'><span class="al-trigger-inner"><%= t :manage_discussion, 'Manage Discussion' %></span></button>
<ul class="al-options">
<% if can_do(@topic, @current_user, :update) %>
<li><a href="<%= context_url(@topic.context, :edit_context_discussion_topic_url, @topic) %>"><span class="ui-icon ui-icon-pencil"></span><%= t :edit, 'Edit' %></a></li>

2
app/views/jst/discussions/_entry_content.handlebars
View File

@ -10,7 +10,7 @@
{{>avatar author}}
<div class="discussion-header-content right-of-avatar">
<div class="hide-if-collapsed admin-links">
<button class="al-trigger ui-button" data-event="openMenu"><span class="al-trigger-inner">{{#t "manage"}}Manage{{/t}}</span></button>
<button class="al-trigger ui-button" data-event="openMenu"><span class="al-trigger-inner">{{#t "manage_discussion_entry"}}Manage Discussion Entry{{/t}}</span></button>
<ul class="al-options">
<li><a href="#{{#if parent_cid}}{{parent_cid}}{{else}}content{{/if}}"><span class="ui-icon ui-icon-arrowreturnthick-1-w" />{{#t "go_to_parent"}}Go To Parent{{/t}}</a></li>
{{#if canModerate}}