From 566d6c29af98b216da49703d720beebd445c8461 Mon Sep 17 00:00:00 2001 From: Simon Williams Date: Wed, 28 Jul 2021 20:35:02 -0500 Subject: [PATCH] small manage_assignments cleanup Change-Id: Ie8bc261ef5bf5f27f5450e355d077dbad679dc5d Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271084 Tested-by: Service Cloud Jenkins Reviewed-by: Cody Cutrer QA-Review: Simon Williams Product-Review: Simon Williams --- app/controllers/assignments_api_controller.rb | 2 +- app/models/assignment.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/assignments_api_controller.rb b/app/controllers/assignments_api_controller.rb index ed199013480..2eccc55831f 100644 --- a/app/controllers/assignments_api_controller.rb +++ b/app/controllers/assignments_api_controller.rb @@ -799,7 +799,7 @@ class AssignmentsApiController < ApplicationController scope = SortsAssignments.bucket_filter(scope, params[:bucket], session, user, @current_user, @context, submissions_for_user) end - scope = scope.where(post_to_sis: value_to_boolean(params[:post_to_sis])) if params[:post_to_sis] && authorized_action(@context, user, :manage_assignments) + scope = scope.where(post_to_sis: value_to_boolean(params[:post_to_sis])) if params[:post_to_sis] if params[:assignment_ids] if params[:assignment_ids].length > Api.max_per_page diff --git a/app/models/assignment.rb b/app/models/assignment.rb index 4cd1a109a70..4f81d8dac20 100644 --- a/app/models/assignment.rb +++ b/app/models/assignment.rb @@ -1725,7 +1725,7 @@ class Assignment < ActiveRecord::Base can :manage_files_delete given { |user, session| self.context.grants_right?(user, session, :manage_assignments) } - can :create and can :read and can :attach_submission_comment_files + can :create and can :read given { |user, session| self.user_can_update?(user, session) } can :update