ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't lookup sections by name 

it is not a suitable unique identifier, as evidenced by actual data

Change-Id: Ib2b2f6d523b2ad052b4eff9a35c10a6e62d394c5
Reviewed-on: https://gerrit.instructure.com/3565
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
This commit is contained in:
Cody Cutrer 2011-05-10 09:09:41 -06:00
parent 52fd347a6c
commit 50173ca63f
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/sis/section_importer.rb
View File

@ -58,7 +58,6 @@ module SIS
name = row['name']
section = CourseSection.find_by_root_account_id_and_sis_source_id(@root_account.id, row['section_id'])
section ||= course.course_sections.find_by_sis_source_id(row['section_id'])
section ||= course.course_sections.find_by_name(name)
section ||= course.course_sections.new
section.root_account = @root_account
# this is an easy way to load up the cache with data we already have