ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't allow students to have view reports permission 

fixes CNVS-12085

test plan
 - before updating set the "View usage reports
   for the course" permission to enabled
 - /accounts/84968/permissions
 - should not be able to enable "View usage reports
   for the course" permission for students

Change-Id: I60e817641436230564b0a50a8a7d46e29cb355a6
Reviewed-on: https://gerrit.instructure.com/32509
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nick Cloward <ncloward@instructure.com>
QA-Review: August Thornton <august@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
This commit is contained in:
Rob Orton 2014-03-28 09:25:16 -06:00
parent 0a2416cdec
commit 443b55d589
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/role_overrides_controller.rb
View File

@ -1,5 +1,5 @@
#
# Copyright (C) 2011 Instructure, Inc.
# Copyright (C) 2011 - 2014 Instructure, Inc.
#
# This file is part of Canvas.
#
@ -249,7 +249,7 @@ class RoleOverridesController < ApplicationController
# moderate_forum -- [sTADo] Moderate discussions (delete/edit others' posts, lock topics)
# post_to_forum -- [STADo] Post to discussions
# read_question_banks -- [ TADo] View and link to question banks
# read_reports -- [sTAD ] View usage reports for the course
# read_reports -- [ TAD ] View usage reports for the course
# read_roster -- [STADo] See the list of users
# read_sis -- [sTa ] Read SIS data
# send_messages -- [STADo] Send messages to individual course members

3
app/models/role_override.rb
View File

@ -1,5 +1,5 @@
#
# Copyright (C) 2011 Instructure, Inc.
# Copyright (C) 2011 - 2014 Instructure, Inc.
#
# This file is part of Canvas.
#
@ -556,7 +556,6 @@ class RoleOverride < ActiveRecord::Base
:read_reports => {
:label => lambda { t('permissions.read_reports', "View usage reports for the course") },
:available_to => [
'StudentEnrollment',
'TaEnrollment',
'DesignerEnrollment',
'TeacherEnrollment',