ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spec: add required canAddObservee prop for K5Dashboard 

Closes LS-2713

Test Plan: passes Jenkins

Change-Id: I27d57fc670d1ecda7345581cba9a93c5fb075424
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
This commit is contained in:
Robin Kuss 2021-10-07 09:45:37 -05:00
parent b72cd379c8
commit 41c08d69da
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jest/jest-setup.js
View File

@ -78,7 +78,6 @@ const ignoredErrors = [
/The above error occurred in the <.*> component/,
/The prop `activeMailbox` is marked as required in `MailboxSelectionDropdown`/,
/The prop `avatarName` is marked as required in `UserLink`/,
/The prop `canAddObservee` is marked as required in `(K5Dashboard|ObserverOptions|ResponsiveK5Dashboard)`/,
/The prop `canReadAnnouncements` is marked as required in `(K5Announcement|K5Course)`/,
/The prop `children` is marked as required in `TruncateText`/,
/The prop `color` is marked as required in `StatusColorListItem`/,

5
ui/features/k5_dashboard/react/__tests__/K5Dashboard.test.js
View File

@ -184,6 +184,7 @@ const defaultProps = {
currentUserRoles: ['admin'],
createPermissions: null,
plannerEnabled: false,
loadingOpportunities: false,
loadAllOpportunities: () => {},
timeZone: defaultEnv.TIMEZONE,
hideGradesTabForStudents: false,
@ -191,6 +192,7 @@ const defaultProps = {
selectedContextCodes: ['course_1', 'course_3'],
selectedContextsLimit: 2,
parentSupportEnabled: false,
canAddObservee: false,
observerList: MOCK_OBSERVER_LIST
}
@ -795,6 +797,7 @@ describe('K-5 Dashboard', () => {
<K5Dashboard
{...defaultProps}
parentSupportEnabled
canAddObservee
currentUserRoles={['user', 'observer']}
/>
)
@ -809,6 +812,7 @@ describe('K-5 Dashboard', () => {
<K5Dashboard
{...defaultProps}
currentUserRoles={['user', 'observer', 'teacher']}
canAddObservee
parentSupportEnabled
/>
)
@ -832,6 +836,7 @@ describe('K-5 Dashboard', () => {
{...defaultProps}
currentUserRoles={['user', 'observer', 'teacher']}
parentSupportEnabled
canAddObservee
/>
)
const select = getByRole('combobox', {name: 'Select a student to view'})