From 3db851750dfb5b171f7a8363f3f726a578494c4e Mon Sep 17 00:00:00 2001 From: Tucker McKnight Date: Mon, 25 Jun 2018 16:37:28 -0600 Subject: [PATCH] spec: Reset DB counter in set_up, not tear_down This avoids a problem where, if the tear_down doesn't happen (say, if the process is aborted), things wouldn't have been reset for the next run. By doing it in the set_up, we can always count on IDs starting at 1 every time the tests run. Change-Id: I90ab810c03ea7f153dabc40b346d92bb2a11726f Reviewed-on: https://gerrit.instructure.com/155194 Tested-by: Jenkins Reviewed-by: Anju Reddy Product-Review: Tucker McKnight QA-Review: Tucker McKnight --- spec/contracts/service_consumers/api/pact_setup.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/spec/contracts/service_consumers/api/pact_setup.rb b/spec/contracts/service_consumers/api/pact_setup.rb index 7231bd94f5d..952e7cee654 100644 --- a/spec/contracts/service_consumers/api/pact_setup.rb +++ b/spec/contracts/service_consumers/api/pact_setup.rb @@ -24,11 +24,12 @@ end Pact.set_up do DatabaseCleaner.strategy = :transaction DatabaseCleaner.start -end -Pact.tear_down do - DatabaseCleaner.clean ActiveRecord::Base.connection.tables.each do |t| ActiveRecord::Base.connection.reset_pk_sequence!(t) end end + +Pact.tear_down do + DatabaseCleaner.clean +end