ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor quiz creation specs, add new ones 

Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails

Change-Id: I45ddc0957149dbde4075f90ded79ffc6e755b1b0
Reviewed-on: https://gerrit.instructure.com/64065
Tested-by: Jenkins
Reviewed-by: Adam Phillipps <adam@instructure.com>
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
This commit is contained in:
Michael Hargiss 2015-09-23 18:24:56 -06:00 committed by Derek Hansen
parent 079c9e272c
commit 3902bac824
3 changed files with 177 additions and 79 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
spec/selenium/helpers/quizzes_common.rb
View File

@ -13,6 +13,25 @@ require_relative "../common"
@quiz
end
# The default time for a quiz due date is 11:59pm
def default_time_for_due_date(date)
date.change({ hour: 23, min: 59 })
end
# The default time for a quiz lock date is 11:59pm
def default_time_for_lock_date(date)
date.change({ hour: 23, min: 59 })
end
# The default time for a quiz unlock date is 12am
def default_time_for_unlock_date(date)
date.change({ hour: 0, min: 0 })
end
def assign_quiz_to_no_one
f('.ContainerDueDate .ic-token-delete-button').click
end
def create_multiple_choice_question
question = fj(".question_form:visible")
click_option('.question_form:visible .question_type', 'Multiple Choice')

158
spec/selenium/quizzes/quizzes_create_quiz_teacher_spec.rb Normal file
View File

@ -0,0 +1,158 @@
require File.expand_path(File.dirname(__FILE__) + '/../helpers/quizzes_common')
require File.expand_path(File.dirname(__FILE__) + '/../helpers/assignment_overrides')
require File.expand_path(File.dirname(__FILE__) + '/../helpers/files_common')
describe 'creating a quiz' do
include AssignmentOverridesSeleniumHelper
include_context 'in-process server selenium tests'
context 'as a teacher' do
before(:each) do
course_with_teacher_logged_in(course_name: 'Test Course', active_all: true)
end
context 'when the course has two sections' do
before(:each) do
@section_a = @course.course_sections.first
@section_b = @course.course_sections.create!(name: 'Section B')
course_quiz(active: true)
get "/courses/#{@course.id}/quizzes/#{@quiz.id}/edit"
end
it 'sets availability dates and due dates for each section', priority: 1, test_id: 140670 do
assign_quiz_to_no_one
# assign to default section
now = Time.zone.now
due_at_a = default_time_for_due_date(now.advance(days: 3))
unlock_at_a = default_time_for_unlock_date(now.advance(days: -3))
lock_at_a = default_time_for_lock_date(now.advance(days: 3))
assign_dates_for_first_override_section(
due_at: due_at_a,
unlock_at: unlock_at_a,
lock_at: lock_at_a
)
# assign to Section B
due_at_b = default_time_for_due_date(now.advance(days: 5))
unlock_at_b = default_time_for_unlock_date(now.advance(days: -1))
lock_at_b = default_time_for_lock_date(now.advance(days: 5))
add_override
assign_dates_for_last_override_section(
due_at: due_at_b,
unlock_at: unlock_at_b,
lock_at: lock_at_b
)
# Must select sections after setting dates in order to avoid intermittent failure.
# Workaround is to set the dates using the date-selector tools.
select_first_override_section(@section_a.name)
select_last_override_section(@section_b.name)
save_settings
# verify default section due date & availability dates
expect(obtain_due_date(@section_a)).to include_text("#{format_time_for_view(due_at_a)}")
expect(obtain_availability_start_date(@section_a)).to include_text("#{format_time_for_view(unlock_at_a)}")
expect(obtain_availability_end_date(@section_a)).to include_text("#{format_time_for_view(lock_at_a)}")
# verify Section B due date & availability dates
expect(obtain_due_date(@section_b)).to include_text("#{format_time_for_view(due_at_b)}")
expect(obtain_availability_start_date(@section_b)).to include_text("#{format_time_for_view(unlock_at_b)}")
expect(obtain_availability_end_date(@section_b)).to include_text("#{format_time_for_view(lock_at_b)}")
end
end
it 'prevents assigning a quiz to no one', priority: 1, test_id: 385155 do
course_quiz(active: true)
get "/courses/#{@course.id}/quizzes/#{@quiz.id}/edit"
assign_quiz_to_no_one
save_settings
expect(ffj('div.error_text', 'div.error_box.errorBox')[1].text).to eq 'You must have a student or section selected'
end
it 'saves and publishes a new quiz', priority: "1", test_id: 193785 do
@quiz = course_quiz
get "/courses/#{@course.id}/quizzes/#{@quiz.id}/edit"
expect(f('#quiz-draft-state')).to be_displayed
expect_new_page_load {f('.save_and_publish').click}
expect(f('#quiz-publish-link.btn-published')).to be_displayed
# Check that the list of quizzes is also updated
get "/courses/#{@course.id}/quizzes"
expect(f("#summary_quiz_#{@quiz.id} .icon-publish")).to be_displayed
end
it 'creates a quiz directly from the index page', priority: "1", test_id: 210055 do
get "/courses/#{@course.id}/quizzes"
expect_new_page_load { f('.new-quiz-link').click }
expect_new_page_load do
click_save_settings_button
wait_for_ajax_requests
end
expect(f('#quiz_title')).to include_text 'Unnamed Quiz'
end
it 'creates and previews a new quiz', priority: "1", test_id: 210056 do
get "/courses/#{@course.id}/quizzes"
expect_new_page_load do
f('.new-quiz-link').click
wait_for_ajaximations
end
# check url
expect(driver.current_url).to match %r{/courses/\d+/quizzes/(\d+)\/edit}
# check quiz id
# The =~ operator compares the regex with the string.
# The (?<quiz_id>(\d+)) part of the regex tells the =~ to assign
# the value of the number found therein to the variable, quiz_id.
%r courses/\d+/quizzes/(?<quiz_id>(\d+))/edit =~ driver.current_url
expect(quiz_id.to_i).to be > 0
# input name and description then save quiz
replace_content(f('#quiz_title'), 'new quiz')
test_text = 'new description'
keep_trying_until { expect(f('#quiz_description_ifr')).to be_displayed }
type_in_tiny '#quiz_description', test_text
in_frame 'quiz_description_ifr' do
expect(f('#tinymce')).to include_text(test_text)
end
# add a question
click_questions_tab
click_new_question_button
submit_form('.question_form')
wait_for_ajaximations
# save the quiz
expect_new_page_load do
click_save_settings_button
wait_for_ajaximations
end
wait_for_ajaximations
# check quiz preview
f('#preview_quiz_button').click
expect(f('#questions')).to be_present
end
it 'inserts files using the rich content editor', priority: "1", test_id: 132545 do
txt_files = ['some test file', 'b_file.txt']
txt_files.map do |text_file|
file = @course.attachments.create!(display_name: text_file, uploaded_data: default_uploaded_data)
file.context = @course
file.save!
end
@quiz = course_quiz
get "/courses/#{@course.id}/quizzes/#{@quiz.id}/edit"
insert_file_from_rce(:quiz)
expect(fln('b_file.txt')).to be_displayed
end
end
end

79
spec/selenium/quizzes_teacher_spec.rb
View File

@ -24,23 +24,6 @@ describe "quizzes" do
@course.reload
end
context "save and publish button" do
it "should save and publish a quiz", priority: "1", test_id: 193785 do
@quiz = course_quiz
get "/courses/#{@course.id}/quizzes/#{@quiz.id}/edit"
expect(f("#quiz-draft-state")).to be_displayed
expect_new_page_load {f(".save_and_publish").click}
expect(f("#quiz-publish-link.btn-published")).to be_displayed
# Check that the list of quizzes is also updated
get "/courses/#{@course.id}/quizzes"
expect(f("#summary_quiz_#{@quiz.id} .icon-publish")).to be_displayed
end
end
it "should show a summary of due dates if there are multiple", priority: "1", test_id: 210054 do
create_quiz_with_due_date
get "/courses/#{@course.id}/quizzes"
@ -56,68 +39,6 @@ describe "quizzes" do
expect(tooltip).to include_text 'Everyone else'
end
it "should allow a teacher to create a quiz from the quizzes tab directly", priority: "1", test_id: 210055 do
get "/courses/#{@course.id}/quizzes"
expect_new_page_load { f(".new-quiz-link").click }
expect_new_page_load do
click_save_settings_button
wait_for_ajax_requests
end
expect(f('#quiz_title')).to include_text "Unnamed Quiz"
end
it "should create and preview a new quiz", priority: "1", test_id: 210056 do
get "/courses/#{@course.id}/quizzes"
expect_new_page_load do
f('.new-quiz-link').click
wait_for_ajaximations
end
#check url
expect(driver.current_url).to match %r{/courses/\d+/quizzes/(\d+)\/edit}
driver.current_url =~ %r{/courses/\d+/quizzes/(\d+)\/edit}
quiz_id = $1.to_i
expect(quiz_id).to be > 0
#input name and description then save quiz
replace_content(f('#quiz_title'), 'new quiz')
test_text = "new description"
keep_trying_until { expect(f('#quiz_description_ifr')).to be_displayed }
type_in_tiny '#quiz_description', test_text
in_frame "quiz_description_ifr" do
expect(f('#tinymce')).to include_text(test_text)
end
#add a question
click_questions_tab
click_new_question_button
submit_form('.question_form')
wait_for_ajaximations
#save the quiz
expect_new_page_load {
click_save_settings_button
wait_for_ajaximations
}
wait_for_ajaximations
#check quiz preview
f('#preview_quiz_button').click
expect(f('#questions')).to be_present
end
it "should insert multiple files using RCE in the quiz", priority: "1", test_id: 132545 do
txt_files = ["some test file", "b_file.txt"]
txt_files.map do |text_file|
file = @course.attachments.create!(display_name: text_file, uploaded_data: default_uploaded_data)
file.context = @course
file.save!
end
@quiz = course_quiz
get "/courses/#{@course.id}/quizzes/#{@quiz.id}/edit"
insert_file_from_rce(:quiz)
expect(fln("b_file.txt")).to be_displayed
end
it "should asynchronously load student quiz results", priority: "2", test_id: 210058 do
@context = @course
q = quiz_model