drop attachment_id and artifact_type from eportfolio_entries

these columns have not been used

closes CNVS-21492

Change-Id: Ifb592364a5aec9bfa42baabbffc92679cbff337d
Reviewed-on: https://gerrit.instructure.com/57093
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

app/models/eportfolio_entry.rb

@@ -20,13 +20,15 @@ require 'atom'
 require 'sanitize'
 
 class EportfolioEntry < ActiveRecord::Base
-  attr_accessible :eportfolio, :eportfolio_category, :name, :artifact_type, :attachment, :allow_comments, :show_comments, :url
+  attr_accessible :eportfolio, :eportfolio_category, :name, :allow_comments, :show_comments, :url
   attr_readonly :eportfolio_id, :eportfolio_category_id
   belongs_to :eportfolio, touch: true
   belongs_to :eportfolio_category
 
-  EXPORTABLE_ATTRIBUTES = [:id, :eportfolio_id, :eportfolio_category_id, :position, :name, :artifact_type, :attachment_id, :allow_comments, :show_comments, :slug, :url, :content, :created_at, :updated_at]
-  EXPORTABLE_ASSOCIATIONS = [:eportfolio, :eportfolio_category]
+  EXPORTABLE_ATTRIBUTES = [:id, :eportfolio_id, :eportfolio_category_id,
+                           :position, :name, :allow_comments, :show_comments,
+                           :slug, :url, :content, :created_at, :updated_at].freeze
+  EXPORTABLE_ASSOCIATIONS = [:eportfolio, :eportfolio_category].freeze
 
   acts_as_list :scope => :eportfolio_category
   before_save :infer_unique_slug

config/initializers/dropped_columns.rb

@@ -84,6 +84,7 @@ class ActiveRecord::Base
                         can_participate_before_start_at
                         limit_priveleges_to_course_sections
                         role_name).freeze,
+    'eportfolio_entries' => %w(attachment_id artifact_type).freeze,
     'external_feeds' => %w(body_match feed_type feed_purpose).freeze,
     'failed_jobs' => %w(original_id).freeze,
     'gradebook_uploads' => %w(context_type context_id).freeze,

db/migrate/20150623232112_drop_attachment_and_artifact_type_from_eportfolio_entries.rb

@@ -0,0 +1,13 @@
+class DropAttachmentAndArtifactTypeFromEportfolioEntries < ActiveRecord::Migration
+  tag :postdeploy
+
+  def up
+    remove_column :eportfolio_entries, :attachment_id
+    remove_column :eportfolio_entries, :artifact_type
+  end
+
+  def down
+    add_column :eportfolio_entries, :attachment_id, :integer, limit: 8
+    add_column :eportfolio_entries, :artifact_type, :integer
+  end
+end