Remove rce_auto_save flag

Closes MAT-131
flag=none

Test Plan
- Navigate to a root account and verify the RCE
  Autosave feature has been removed
- Navigate to a cousre and verify the RCE Autosave
  feature has been removed
- Open a few RCEs in a course and verify the autosave
  feature is working

Change-Id: I10f88b35501ae5499f6d066e539f953055d43b52
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280794
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>

.storybook/preview.js

@@ -7,9 +7,7 @@ import '@instructure/canvas-high-contrast-theme'
 import '@instructure/canvas-theme'
 
 window.ENV = window.ENV || {
-  FEATURES: {
-    rce_auto_save: true
-  },
+  FEATURES: {},
   // the RCE won't load w/o these yet
   context_asset_string: 'course_1',
   current_user_id: 2

app/controllers/application_controller.rb

@@ -196,7 +196,6 @@ class ApplicationController < ActionController::Base
           DOMAIN_ROOT_ACCOUNT_ID: @domain_root_account&.global_id,
           k12: k12?,
           use_responsive_layout: use_responsive_layout?,
-          rce_auto_save: @context.try(:feature_enabled?, :rce_auto_save),
           use_rce_a11y_checker_notifications: @context.try(:feature_enabled?, :rce_a11y_checker_notifications),
           help_link_name: help_link_name,
           help_link_icon: help_link_icon,
@@ -249,7 +248,7 @@ class ApplicationController < ActionController::Base
         end
 
         @js_env[:lolcalize] = true if ENV["LOLCALIZE"]
-        @js_env[:rce_auto_save_max_age_ms] = Setting.get("rce_auto_save_max_age_ms", 1.day.to_i * 1000).to_i if @js_env[:rce_auto_save]
+        @js_env[:rce_auto_save_max_age_ms] = Setting.get("rce_auto_save_max_age_ms", 1.day.to_i * 1000).to_i
         @js_env[:FEATURES][:new_math_equation_handling] = use_new_math_equation_handling?
         @js_env[:K5_USER] = k5_user?
         @js_env[:K5_HOMEROOM_COURSE] = @context.is_a?(Course) && @context.elementary_homeroom_course?

config/feature_flags/learning_activities_rce.yml

@@ -1,11 +1,3 @@
-rce_auto_save:
-  state: hidden
-  display_name: RCE Auto-Save
-  description: |-
-    If RCE Enhancements are also enabled,
-    the RCE will auto-save your work as you go
-  applies_to: Course
-  root_opt_in: true
 cc_in_rce_video_tray:
   state: hidden
   display_name: RCE Edit Closed Captions

spec/selenium/rcs/rce_next_autosave_spec.rb

@@ -42,7 +42,6 @@ describe "RCE Next autosave feature", ignore_js_errors: true do
     before do
       Setting.set("rce_auto_save_max_age_ms", 1.hour.to_i * 1_000)
       course_with_teacher_logged_in
-      Account.default.enable_feature!(:rce_auto_save)
       stub_rcs_config
     end
 
@@ -221,7 +220,6 @@ describe "RCE Next autosave feature", ignore_js_errors: true do
     before do
       Setting.set("rce_auto_save_max_age_ms", 1.hour.to_i * 1_000)
       account_with_admin_logged_in
-      Account.default.enable_feature!(:rce_auto_save)
       stub_rcs_config
     end
 

ui/shared/rce/react/CanvasRce.js

@@ -77,7 +77,7 @@ const CanvasRce = forwardRef(function CanvasRce(props, rceRef) {
     return config
   })
   const [autosave_] = useState({
-    enabled: ENV.rce_auto_save && autosave,
+    enabled: true,
     interval: Number.isNaN(ENV.rce_auto_save_max_age_ms) ? 3600000 : ENV.rce_auto_save_max_age_ms
   })
   const [refCreated, setRefCreated] = useState(null)

ui/shared/rce/serviceRCELoader.js

@@ -170,7 +170,7 @@ const RCELoader = {
     // TODO: let client pass autosave_enabled in as a prop from the outside
     //       Assignmens2 student view is going to be doing their own autosave
     const autosave = {
-      enabled: ENV.rce_auto_save,
+      enabled: true,
       maxAge: Number.isNaN(ENV.rce_auto_save_max_age_ms) ? 3600000 : ENV.rce_auto_save_max_age_ms
     }