From 35252ec992550eca6ad6479388d4593afee93c33 Mon Sep 17 00:00:00 2001 From: Michael Nomitch Date: Wed, 21 May 2014 16:34:49 -0500 Subject: [PATCH] stop appending digits to long assignment names fixes CNVS-1662 test plan: - turn draft state off - go to the asignments index - create an assignment group w/ a 254 char name - click the add assignment link on the right side with the newly created assignment group selected - the assignment created should not have a number at the end - it should save properly - click the add assignment link on the right side with a different group (without a long name) - the assignment created should have a number at the end (like usual) Change-Id: I1cb7c1aa80eb698e1e5b84098448817e943e79fa Reviewed-on: https://gerrit.instructure.com/35300 Reviewed-by: Cameron Matheson Tested-by: Jenkins QA-Review: Anna Koalenz Product-Review: Simon Williams --- public/javascripts/assignments.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/public/javascripts/assignments.js b/public/javascripts/assignments.js index f375109caf3..9f66960d6f6 100644 --- a/public/javascripts/assignments.js +++ b/public/javascripts/assignments.js @@ -82,7 +82,9 @@ define([ var $group = $assignment.parents(".assignment_group"); var group_data = $group.getTemplateData({textValues: ['default_assignment_name', 'assignment_group_id']}); var title = group_data.default_assignment_name; - title += " " + $group.find(".group_assignment").length; + if(title.length <= 251){ + title += " " + $group.find(".group_assignment").length; + } var $form = $assignment.find("#add_assignment_form"); var buttonMsg = "Update"; var url = $assignment.find(".edit_assignment_link").attr('href');