spec: clean up planner test flakiness

Closes LS-2978

Test Plan: passes Jenkins, especially flakey_spec_catcher

Change-Id: I2636d0915cfc8626fc712e5abd2655ca885704b5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286753
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>

spec/selenium/admin/pages/student_context_tray_page.rb

@@ -59,7 +59,6 @@ module StudentContextTray
   end
 
   def todo_tray_select_course_from_dropdown(course_name = "Optional: Add Course")
-    todo_tray_course_selector.click
     click_option("#to-do-item-course-select", course_name)
   end
 end

spec/selenium/dashboard/pages/student_planner_page.rb

@@ -276,6 +276,7 @@ module PlannerPageObject
 
   def open_opportunities_dropdown
     fj("button:contains('opportunit')").click
+    wait_for(method: nil, timeout: 1) { f("#Opportunities-styles__tabs_container").displayed? }
   end
 
   def close_opportunities_dropdown
@@ -391,6 +392,7 @@ module PlannerPageObject
     go_to_list_view
     click_item_button(@student_to_do.title)
     @modal = todo_sidebar_modal(@student_to_do.title)
+    wait_for(method: nil, timeout: 1) { todo_tray_course_selector.displayed? }
   end
 
   def graded_discussion_in_the_past(due = Time.zone.now - 2.days, title = "Graded discussion past")

spec/selenium/dashboard/planner/student_planner_spec.rb

@@ -266,7 +266,7 @@ describe "student planner" do
     end
 
     it "edits a To Do", priority: "1" do
-      @student1.planner_notes.create!(todo_date: 2.days.from_now, title: "Title Text")
+      @student1.planner_notes.create!(todo_date: Time.zone.now, title: "Title Text")
       go_to_list_view
       # Opens the To Do edit sidebar
       todo_item = todo_info_holder
@@ -275,8 +275,7 @@ describe "student planner" do
       click_item_button("Title Text")
 
       # gives the To Do a new name and saves it
-      element = title_input("Title Text")
-      replace_content(element, "New Text")
+      title_input("Title Text").send_keys([:control, "a"], :backspace, "New Text")
       todo_save_button.click
 
       # verifies that the edited To Do is showing up
@@ -449,7 +448,12 @@ describe "student planner" do
     end
 
     it "closes the opportunities dropdown.", priority: "1" do
-      skip("Flaky: skip for now LS-2135 to fix")
+      # Adding this today assignment only so that an alert doesn't come up saying Nothing is Due Today
+      # It interferes with the dropdown in Jenkins
+      @course.assignments.create!(name: "assignment due today",
+                                  description: "we need this so we dont get the popup",
+                                  submission_types: "online_text_entry",
+                                  due_at: Time.zone.now)
       go_to_list_view
       open_opportunities_dropdown
       close_opportunities_dropdown