RuboCop: Bundler and Gemspec

Change-Id: I3077a90ba421f5996bb7ef2d4b7d85c2134b4c11
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274193
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

.rubocop.common.yml

@@ -14,8 +14,12 @@ AllCops:
 Bundler/OrderedGems:
   Enabled: false # this isn't good for us because of how we pin dependencies
 
-Gemspec/OrderedDependencies:
+Gemspec/RequiredRubyVersion:
-  Enabled: false # this isn't good for us because of how we pin dependencies
+  # all the gemspecs in this repo are non-published gems
+  # the root Gemfile enforces the Ruby version, and we purposely
+  # don't specify required_ruby_version in the rest to reduce
+  # maintenance pain when updating ruby versions
+  Enabled: false
 
 Layout/EmptyLineAfterMagicComment:
   Exclude:

.rubocop.enforced.yml

@@ -16,6 +16,8 @@ AllCops:
 # values are an array of directories to opt in for (nil being all directories)
 OPT_IN = {
   nil => %w[Gemfile.d].freeze,
+  'Bundler' => nil,
+  'Gemspec' => nil,
   'Layout' => %w[bin build config db doc engines gems script].freeze
 }.freeze
 

engines/audits/audits.gemspec

@@ -15,14 +15,14 @@ Gem::Specification.new do |spec|
   spec.description = "append-only log of important changes within canvas"
   spec.files = Dir["{app,config,db,lib}/**/*", "Rakefile", "README.md"]
 
-  spec.add_dependency "rails", ">= 5.2.4.5"
-  spec.add_dependency "switchman", '>= 2.0.3'
   spec.add_dependency "canvas_cassandra"
   spec.add_dependency "dynamic_settings"
   spec.add_dependency "event_stream"
+  spec.add_dependency "rails", ">= 5.2.4.5"
+  spec.add_dependency "switchman", '>= 2.0.3'
 
-  spec.add_development_dependency "pg"
-  spec.add_development_dependency "rspec-rails"
   spec.add_development_dependency "brakeman"
   spec.add_development_dependency "byebug"
+  spec.add_development_dependency "pg"
+  spec.add_development_dependency "rspec-rails"
 end

gems/acts_as_list/acts_as_list.gemspec

@@ -21,6 +21,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rails', ">= 3.2"
 
   spec.add_development_dependency "bundler", ">= 1.5", "< 3.0"
-  spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "rspec", "~> 3.5.0"
+  spec.add_development_dependency "sqlite3"
 end

gems/autoextend/autoextend.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.0'
 
-  spec.add_development_dependency "byebug"
   spec.add_development_dependency "activesupport"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "rspec", "~> 3.5.0"
 end

gems/bookmarked_collection/bookmarked_collection.gemspec

@@ -17,15 +17,15 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "folio-pagination", "~> 0.0.12"
-  spec.add_dependency "will_paginate", "~> 3.0"
   spec.add_dependency "rails", ">= 3.2"
+  spec.add_dependency "will_paginate", "~> 3.0"
 
-  spec.add_dependency "paginated_collection"
   spec.add_dependency "json_token"
+  spec.add_dependency "paginated_collection"
 
   spec.add_development_dependency "bundler", "~> 2.2"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
   spec.add_development_dependency "sqlite3"
-  spec.add_development_dependency "byebug"
 end

gems/broadcast_policy/broadcast_policy.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency "activesupport"
   s.add_dependency "after_transaction_commit"
-  s.add_development_dependency "rspec", "~> 3.5.0"
   s.add_development_dependency "byebug"
   s.add_development_dependency "pry"
+  s.add_development_dependency "rspec", "~> 3.5.0"
 end

gems/canvas_cache/canvas_cache.gemspec

@@ -20,15 +20,15 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rails'
 
   # redis things required in canvas
+  spec.add_dependency 'digest-murmurhash', '>= 1.1.0'
   spec.add_dependency 'redis', '>= 4.1.0'
   spec.add_dependency 'redis-scripting', '>= 1.0.0'
-  spec.add_dependency 'digest-murmurhash', '>= 1.1.0'
 
   spec.add_dependency 'guardrail', '>= 2.0.0'
   spec.add_dependency 'inst_statsd', '>= 2.1.0'
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'timecop'
 end

gems/canvas_cassandra/canvas_cassandra.gemspec

@@ -19,11 +19,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency 'cassandra-cql', '~> 1.2.2'
-  spec.add_dependency "rails", ">= 5.0"
   spec.add_dependency "config_file"
+  spec.add_dependency "rails", ">= 5.0"
 
   spec.add_development_dependency "bundler", "~> 2.2"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
-  spec.add_development_dependency "byebug"
 end

gems/canvas_dynamodb/canvas_dynamodb.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'aws-sdk-dynamodb', '~> 1.32'
   spec.add_runtime_dependency 'aws-sdk-applicationautoscaling', '~> 1.26'
+  spec.add_runtime_dependency 'aws-sdk-dynamodb', '~> 1.32'
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake"

gems/canvas_errors/canvas_errors.gemspec

@@ -20,6 +20,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'inst-jobs'
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'rspec'
 end

gems/canvas_ext/canvas_ext.gemspec

@@ -16,8 +16,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "tzinfo"
   spec.add_dependency "activesupport", ">= 3.2"
+  spec.add_dependency "tzinfo"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake"

gems/canvas_http/canvas_http.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency "multipart"
 
   spec.add_development_dependency "bundler", "~> 2.2"
+  spec.add_development_dependency "multipart"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
-  spec.add_development_dependency "multipart"
   spec.add_development_dependency "webmock", "1.24.6"
 end

gems/canvas_kaltura/canvas_kaltura.gemspec

@@ -16,11 +16,11 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "nokogiri"
   spec.add_dependency "canvas_http"
+  spec.add_dependency "canvas_slug"
   spec.add_dependency "canvas_sort"
   spec.add_dependency "multipart"
-  spec.add_dependency "canvas_slug"
+  spec.add_dependency "nokogiri"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake"

gems/canvas_partman/canvas_partman.gemspec

@@ -15,8 +15,8 @@ Gem::Specification.new do |spec|
   spec.license       = 'AGPL'
 
   spec.add_dependency 'activerecord', '>= 3.2'
-  spec.add_dependency 'pg', '>= 0.17', '< 2.0'
   spec.add_dependency 'activerecord-pg-extensions', '>= 0.3.0'
+  spec.add_dependency 'pg', '>= 0.17', '< 2.0'
 
   spec.add_development_dependency 'bundler', '~> 2.2'
   spec.add_development_dependency 'rspec', '~> 3.5.0'

gems/canvas_quiz_statistics/canvas_quiz_statistics.gemspec

@@ -17,11 +17,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'html_text_helper'
 
   spec.add_development_dependency 'bundler', '~> 2.2'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', "~> 3.5.0"
   spec.add_development_dependency 'byebug'
   spec.add_development_dependency 'guard'
   spec.add_development_dependency 'guard-rspec'
-  spec.add_development_dependency 'terminal-notifier-guard'
   spec.add_development_dependency 'listen', "3.0.8"
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec', "~> 3.5.0"
+  spec.add_development_dependency 'terminal-notifier-guard'
 end

gems/canvas_security/canvas_security.gemspec

@@ -18,12 +18,12 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'canvas_cache'
   spec.add_dependency 'canvas_errors'
-  spec.add_dependency 'rails'
-  spec.add_dependency 'json-jwt', '1.13.0'
   spec.add_dependency 'dynamic_settings'
+  spec.add_dependency 'json-jwt', '1.13.0'
+  spec.add_dependency 'rails'
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'timecop'
 end

gems/canvas_stringex/canvas_stringex.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "activerecord"
   spec.add_development_dependency "bundler", ">= 1.5", "< 3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "RedCloth"
   spec.add_development_dependency "rspec", "~> 3.5.0"
+  spec.add_development_dependency "sqlite3"
 end

gems/config_file/config_file.gemspec

@@ -19,6 +19,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rails', ">= 5.0"
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'rspec'
 end

gems/dr_diff/dr_diff.gemspec

@@ -16,8 +16,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "gergich", "1.2.1"
-  spec.add_development_dependency "rspec", "~> 3.5.0"
-  spec.add_development_dependency "rspec-mocks"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "pry-nav"
+  spec.add_development_dependency "rspec", "~> 3.5.0"
+  spec.add_development_dependency "rspec-mocks"
 end

gems/dynamic_settings/dynamic_settings.gemspec

@@ -22,6 +22,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'railties'
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'rspec'
 end

gems/google_drive/google_drive.gemspec

@@ -20,9 +20,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency  "google-api-client", "0.8.2"
 
   spec.add_development_dependency "bundler"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
-  spec.add_development_dependency "byebug"
   spec.add_development_dependency "timecop"
   spec.add_development_dependency "webmock"
   spec.add_dependency 'faraday', '~> 0.17.3'

gems/html_text_helper/html_text_helper.gemspec

@@ -16,9 +16,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency 'canvas_text_helper'
   spec.add_dependency 'nokogiri'
   spec.add_dependency 'sanitize', '~> 5.2'
-  spec.add_dependency 'canvas_text_helper'
 
   spec.add_dependency 'activesupport', ">= 3.2"
 

gems/i18n_extraction/i18n_extraction.gemspec

@@ -16,10 +16,10 @@ Gem::Specification.new do |spec|
   spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "sexp_processor", "~> 4.14", ">= 4.14.1"
-  spec.add_dependency "ruby_parser", "~> 3.7"
   spec.add_dependency "activesupport", ">= 3.2"
   spec.add_dependency "i18nliner", "~> 0.1"
+  spec.add_dependency "ruby_parser", "~> 3.7"
+  spec.add_dependency "sexp_processor", "~> 4.14", ">= 4.14.1"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake"

gems/i18n_tasks/i18n_tasks.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activesupport", ">= 3.2"
 
   spec.add_dependency "i18n", ">= 0.7", "< 2"
-  spec.add_dependency "ruby_parser", "~> 3.7"
   spec.add_dependency "i18n_extraction"
+  spec.add_dependency "ruby_parser", "~> 3.7"
   spec.add_dependency "utf8_cleaner"
 
   spec.add_development_dependency "bundler", "~> 2.2"

gems/incoming_mail_processor/incoming_mail_processor.gemspec

@@ -18,12 +18,12 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activesupport", ">= 3.2"
 
-  spec.add_dependency "mail", "~> 2.7.0"
-  spec.add_dependency "html_text_helper"
-  spec.add_dependency "utf8_cleaner"
-  spec.add_dependency "inst_statsd"
   spec.add_dependency "aws-sdk-s3"
   spec.add_dependency "aws-sdk-sqs"
+  spec.add_dependency "html_text_helper"
+  spec.add_dependency "inst_statsd"
+  spec.add_dependency "mail", "~> 2.7.0"
+  spec.add_dependency "utf8_cleaner"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "byebug"

gems/inst_access/inst_access.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'json-jwt', '1.13.0'
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'byebug'
+  spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'timecop'
 end

gems/linked_in/linked_in.gemspec

@@ -16,8 +16,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "oauth"
   spec.add_dependency "nokogiri"
+  spec.add_dependency "oauth"
 
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake"

gems/live_events/live_events.gemspec

@@ -16,12 +16,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "activesupport"
   spec.add_dependency "aws-sdk-kinesis"
   spec.add_dependency "inst_statsd"
-  spec.add_dependency "activesupport"
 
   spec.add_development_dependency "bundler", "~> 2.2"
-  spec.add_development_dependency "rake"
   spec.add_development_dependency "byebug"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
 end

gems/lti-advantage/lti-advantage.gemspec

@@ -28,11 +28,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'json-jwt', '~> 1.5'
   spec.add_runtime_dependency "activemodel", ">= 5.1"
+  spec.add_runtime_dependency 'json-jwt', '~> 1.5'
 
-  spec.add_development_dependency "redcarpet"
   spec.add_development_dependency "bundler", "~> 2.2"
   spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "redcarpet"
   spec.add_development_dependency "rspec", "~> 3.0"
 end

gems/multipart/multipart.gemspec

@@ -16,12 +16,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "mime-types", "~> 3.2"
   spec.add_dependency "canvas_slug"
+  spec.add_dependency "mime-types", "~> 3.2"
 
   spec.add_development_dependency "bundler", "~> 2.2"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.5.0"
   spec.add_development_dependency "rack", "~> 1.6"
   spec.add_development_dependency "rack-test", "0.6.2"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec", "~> 3.5.0"
 end

gems/plugins/academic_benchmark/academic_benchmark.gemspec

@@ -15,6 +15,6 @@ Gem::Specification.new do |spec|
   spec.files = Dir["{app,config,db,lib}/**/*"]
   spec.test_files = Dir["spec_canvas/**/*"]
 
-  spec.add_dependency "rails", ">= 3.2"
   spec.add_dependency "academic_benchmarks", "~> 1.1.0"
+  spec.add_dependency "rails", ">= 3.2"
 end

gems/plugins/moodle_importer/moodle_importer.gemspec

@@ -18,6 +18,6 @@ Gem::Specification.new do |s|
   s.files = Dir["{lib}/**/*"]
   s.test_files = Dir["spec_canvas/**/*"]
 
-  s.add_dependency "rails", ">= 3.2"
   s.add_dependency "moodle2cc", "0.2.41"
+  s.add_dependency "rails", ">= 3.2"
 end

gems/request_context/request_context.gemspec

@@ -16,8 +16,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'canvas_security'
   spec.add_dependency 'actionpack'
+  spec.add_dependency 'canvas_security'
   spec.add_dependency 'railties'
 
   spec.add_development_dependency 'bundler'

gems/rubocop-canvas/rubocop-canvas.gemspec

@@ -22,9 +22,9 @@ Gem::Specification.new do |spec|
   spec.add_dependency "rubocop", "~> 1.19"
 
   spec.add_development_dependency "bundler", "~> 2.2"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "pry", "~> 0.10.1"
   spec.add_development_dependency "pry-nav", "~> 0.2.4"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.5.0"
-  spec.add_development_dependency "byebug"
 end

gems/tatl_tael/tatl_tael.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^spec/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "rspec", "~> 3.5.0"
   spec.add_development_dependency "fakefs", "~> 1.2"
+  spec.add_development_dependency "rspec", "~> 3.5.0"
   spec.add_development_dependency "timecop", "0.8.1"
 end

gems/turnitin_api/turnitin_api.gemspec

@@ -18,10 +18,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'simple_oauth', '0.2'
-  spec.add_dependency 'webmock', '3.3.0'
   spec.add_dependency 'faraday', '~> 0.17.3'
   spec.add_dependency 'faraday_middleware', '~> 0.8'
+  spec.add_dependency 'simple_oauth', '0.2'
+  spec.add_dependency 'webmock', '3.3.0'
 
   spec.add_development_dependency "bundler",  "~> 2.2"
   spec.add_development_dependency "rake", "~> 10.0"

gems/twitter/twitter.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "oauth"
 
   spec.add_development_dependency "bundler", "~> 2.2"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.5.0"
-  spec.add_development_dependency "byebug"
 end