try to process zips that use backslashes as path separators

It's not valid for a zip to use backslashes, but some vendors
use them anyway. unzip handles it well so try to process it
anyway

Test Plan:
 * Try to migrate a zip with backslashes
 * It should not fail with a "could not unzip" error

closes #7379

Change-Id: Ie74506bffe70937871d865f63b1b5037b6678b2c
Reviewed-on: https://gerrit.instructure.com/9258
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>

lib/canvas/migration/migrator.rb

@@ -59,6 +59,9 @@ class Migrator
 
     if $?.exitstatus == 0
       return true
+    elsif $?.exitstatus == 1
+      add_warning(I18n.t('canvas.migration.warning.unzip_warning', 'The content package unzipped successfully, but with a warning'), zip_std_out)
+      return true
     elsif $?.exitstatus == 127
       raise "unzip isn't installed on this system, exit status #{$?.exitstatus}, message: #{zip_std_out}"
     else

spec/lib/canvas/migration_spec.rb

@@ -1,48 +1,66 @@
 require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper.rb')
 
-describe "Detecting content package type" do
-  
-  def get_settings(name)
-    path = File.dirname(__FILE__) + "/../../fixtures/migration/package_identifier/#{name}.zip"
-    {:export_archive_path=>path}
-  end
-  
-  supported = {
-          "Canvas Cartridge" => [:canvas, CC::Importer::Canvas::Converter],
-          "Common Cartridge 1.0" => ["cc1-0", CC::Importer::Standard::Converter],
-          "Common Cartridge 1.1" => ["cc1-1", CC::Importer::Standard::Converter],
-          "Common Cartridge 1.2" => ["cc1-2", CC::Importer::Standard::Converter],
-          "QTI packages" => [:qti, Qti::Converter],
-          "WebCT exports (as qti packages)" => [:webct, Qti::Converter],
-  }
-  
-  unsupported = {
-          "Blackboard packages" => [:bb_learn, :bb_learn],
-          "Angel 7.3 packages" => ["angel7-3", :angel_7_3],
-          "Angel 7.4 packages" => ["angel7-4", :angel_7_4],
-          "D2L packages" => [:d2l, :d2l],
-          "Generic IMS Content Package" => [:ims_cp, :unknown_ims_cp_package],
-          "Moodle 1.9 Package" => ["moodle1-9", :moodle_1_9],
-          "Moodle 2 Package" => ["moodle2", :moodle_2],
-          "SCORM 1.1 Package" => ["scorm1-1", :scorm_1_1],
-          "SCORM 1.2 Package" => ["scorm1-2", :scorm_1_2],
-          "SCORM 1.3 Package" => ["scorm1-3", :scorm_1_3],
-          "Unknown zip Package" => ["unknown", :unknown],
-          "WebCT 4.1 Package" => ["webct4-1", :webct_4_1],
-          "Invalid Archive" => [:invalid, :invalid_archive],
-  }
-  
-  supported.each_pair do |key, val|
-    it "should find converter for #{key}" do 
-      settings = get_settings(val.first)
-      Canvas::Migration::Worker::get_converter(settings).should == val.last
+describe "Migration package importers" do
+
+  context "Detecting content package type" do
+    
+    def get_settings(name)
+      path = File.dirname(__FILE__) + "/../../fixtures/migration/package_identifier/#{name}.zip"
+      {:export_archive_path=>path}
+    end
+    
+    supported = {
+            "Canvas Cartridge" => [:canvas, CC::Importer::Canvas::Converter],
+            "Common Cartridge 1.0" => ["cc1-0", CC::Importer::Standard::Converter],
+            "Common Cartridge 1.1" => ["cc1-1", CC::Importer::Standard::Converter],
+            "Common Cartridge 1.2" => ["cc1-2", CC::Importer::Standard::Converter],
+            "QTI packages" => [:qti, Qti::Converter],
+            "WebCT exports (as qti packages)" => [:webct, Qti::Converter],
+    }
+    
+    unsupported = {
+            "Blackboard packages" => [:bb_learn, :bb_learn],
+            "Angel 7.3 packages" => ["angel7-3", :angel_7_3],
+            "Angel 7.4 packages" => ["angel7-4", :angel_7_4],
+            "D2L packages" => [:d2l, :d2l],
+            "Generic IMS Content Package" => [:ims_cp, :unknown_ims_cp_package],
+            "Moodle 1.9 Package" => ["moodle1-9", :moodle_1_9],
+            "Moodle 2 Package" => ["moodle2", :moodle_2],
+            "SCORM 1.1 Package" => ["scorm1-1", :scorm_1_1],
+            "SCORM 1.2 Package" => ["scorm1-2", :scorm_1_2],
+            "SCORM 1.3 Package" => ["scorm1-3", :scorm_1_3],
+            "Unknown zip Package" => ["unknown", :unknown],
+            "WebCT 4.1 Package" => ["webct4-1", :webct_4_1],
+            "Invalid Archive" => [:invalid, :invalid_archive],
+    }
+    
+    supported.each_pair do |key, val|
+      it "should find converter for #{key}" do 
+        settings = get_settings(val.first)
+        Canvas::Migration::Worker::get_converter(settings).should == val.last
+      end
+    end
+    
+    unsupported.each_pair do |key, val|
+      it "should correctly identify package type for #{key}" do 
+        settings = get_settings(val.first)
+        Canvas::Migration::PackageIdentifier.new(settings).identify_package.should == val.last
+      end
     end
   end
   
-  unsupported.each_pair do |key, val|
-    it "should correctly identify package type for #{key}" do 
-      settings = get_settings(val.first)
-      Canvas::Migration::PackageIdentifier.new(settings).identify_package.should == val.last
+  context "migrator" do
+    file = File.new(File.dirname(__FILE__) + "/../../fixtures/migration/whatthebackslash.zip")
+    cm = ContentMigration.new
+    
+    mig = Canvas::Migration::Migrator.new({:archive_file => file, :content_migration => cm}, "test")
+    mig.unzip_archive
+    
+    cm.migration_settings[:warnings].length.should == 1
+    cm.migration_settings[:warnings].first.tap do |w|
+      w.first.should == "The content package unzipped successfully, but with a warning"
+      w.last.should =~ /backslashes as path separators/
     end
   end
+  
 end