spec: fix specs that are fragile in New_UI build

Test Plan:
-specs pass
-code review

Change-Id: Ib4ddd3aa7c7c024c06e687d67b58433c5af269d4
Reviewed-on: https://gerrit.instructure.com/71771
Tested-by: Jenkins
Reviewed-by: Amber Taniuchi <amber@instructure.com>
Product-Review: Amber Taniuchi <amber@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>

spec/selenium/grading_periods_course_spec.rb

@@ -97,14 +97,14 @@ describe 'Course Grading Periods' do
     end
 
     it 'allows a user to save a grading period', priority: "1", test_id: 202317 do
-      grading_period_title = 'grading period name'
+      grading_period_title = 'grading period X'
       get "/courses/#{@course.id}/grading_standards"
       f('#add-period-button').click
-
       replace_content f('#period_title_new2'), grading_period_title
       replace_content f('#period_start_date_new2'), 'Feb 12, 2015 at 12:00am'
       replace_content f('#period_end_date_new2'), 'Feb 22, 2015 at 11:59pm'
       f('.grading-period').click
+      wait_for_ajaximations
       f('#update-button').click
       wait_for_ajax_requests
       expect(GradingPeriod.last.title).to eq(grading_period_title)

spec/selenium/outcome_teacher_spec.rb

@@ -142,8 +142,7 @@ describe "outcomes as a teacher" do
       group = outcome_group_model
       get outcome_url
       wait_for_ajaximations
-
-      fj('.outcomes-sidebar .outcome-link').click
+      f('.outcomes-sidebar .outcome-link').click
       wait_for_ajaximations
 
       f(".move_button").click()
@@ -154,11 +153,11 @@ describe "outcomes as a teacher" do
       expect(ffj('.ui-dialog-content').length).to eq 1
 
       # move the outcome
-      fj('.treeLabel').click
+      f('.treeLabel').click
       wait_for_ajaximations
       ff('[role=treeitem] a span')[1].click
       wait_for_ajaximations
-      fj('.form-controls .btn-primary').click
+      f('.form-controls .btn-primary').click
       wait_for_ajaximations
 
       keep_trying_until do
@@ -177,16 +176,16 @@ describe "outcomes as a teacher" do
       expect(LearningOutcomeGroup.where(id: @outcome_group).first.child_outcome_links.first.content.id).to eq @outcome.id
 
       #confirm that error appears if moving into parent group it already belongs to
-      fj('.outcomes-sidebar .outcome-link').click
+      f('.outcomes-sidebar .outcome-link').click
       wait_for_ajaximations
       f(".move_button").click()
       wait_for_ajaximations
 
-      fj('.treeLabel').click
+      f('.treeLabel').click
       wait_for_ajaximations
 
       ff('[role=treeitem] a span')[1].click
-      fj('.form-controls .btn-primary').click
+      f('.form-controls .btn-primary').click
       wait_for_ajaximations
 
       expect(f('.ic-flash-error').text).to include "first new outcome is already located in new outcome group"

spec/selenium/quizzes/quizzes_teacher_questions_spec.rb

@@ -23,6 +23,7 @@ describe "quizzes questions" do
       wait_for_ajax_requests
 
       click_questions_tab
+      wait_for_ajaximations
       hover_and_click(".edit_question_link")
       wait_for_ajaximations
       question = fj(".question_form:visible")