ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix invalid font/image urls 

fixes CNVS-21857

brandable_css was logging warnings for these image and font urls.
This seems to fix that.

Note there are still a couple warnings for images that actually
don't exist in the repo:

1. /images/inst_tree/node-drag.gif
    (referenced at _inst_tree.scss:97)
2. /images/mediaelement/skipback.png
    (referenced at _mediaelementplayer.scss:977)

Changes included in this commit:

1. canvas-icons svg font url
    (verify at /styleguide#icons)
2. breadcrumbs arrow image url
    (verify that there are no changes to breadcrumbs)
3. loader image in new ui navigation trays
    (click 'Admin' or 'Courses' in new nav with a slow connection)

Change-Id: Ic077717dd20a552e4a3fd28d3dd4f5873f3c926e
Reviewed-on: https://gerrit.instructure.com/58291
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
This commit is contained in:
Jennifer Stern 2015-07-13 14:02:05 -05:00
parent a614b4f600
commit 21e51754f8
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/stylesheets/base/_ic_app_header.scss
View File

@ -30,7 +30,7 @@
position: relative;
height: 100%;
// Use this element to preload the loading image for the secondary nav drawers
background: image-url("/images/panda-cycle-loader.gif") no-repeat -9999px -9999px;
background: url("/images/panda-cycle-loader.gif") no-repeat -9999px -9999px;
}
.ic-app-header__main-navigation {
@ -279,7 +279,7 @@
@include breakpoint(short) { padding-top: $ic-sp/2; }
}
&.ReactTray__loading-list-item {
background: image-url("panda-cycle-loader.gif") no-repeat left center;
background: url("/images/panda-cycle-loader.gif") no-repeat left center;
background-size: 100px;
text-align: center;
color: $ic-dim-helper-text;

6
app/stylesheets/components/_breadcrumbs.scss
View File

@ -12,7 +12,7 @@
@if $use_new_styles {
vertical-align: top;
font-size: 18px;
// temporary solution for new styles before crumbs are re-done:
// temporary solution for new styles before crumbs are re-done:
// we do not want to see the home link
&:first-of-type { display: none; }
&:nth-child(2):before { display: none; }
@ -43,7 +43,7 @@
width: 5px; height: 9px;
display: inline-block;
margin: 0 ($ic-sp - 3);
background: image-url("breadcrumb-arrow-light.svg") no-repeat 50% 50%;
background: url("/images/breadcrumb-arrow-light.svg") no-repeat 50% 50%;
background-size: 5px 9px;
}
@else {
@ -66,4 +66,4 @@
font-size: 10px;
color: $ic-font-color--subdued;
}
}
}

2
app/stylesheets/components/_canvas-icons.scss
View File

@ -297,7 +297,7 @@ Either use `<a>` with icon desired icon class added or insert `<i>` inside `<but
src: url('/fonts/canvas/canvas-icons.eot?#iefix') format('embedded-opentype'),
url('/fonts/canvas/canvas-icons.woff') format('woff'),
url('/fonts/canvas/canvas-icons.ttf') format('truetype'),
url('/fonts/canvas/canvas-webfont.svg#canvasregular') format('svg');
url('/fonts/canvas/canvas-icons.svg#canvas-icons') format('svg');
font-weight: normal;
font-style: normal;
}

3
app/stylesheets/components/_inst_tree.scss
View File

@ -34,7 +34,7 @@ ul.instTree {
background-image: url("/images/groups_folder.png");
}
// &.open
}
&.leaf {
background-image: url("/images/mimeClassIcons/file.svg");
@ -93,6 +93,7 @@ ul.instTree {
z-index: 1000;
position: absolute;
&.node {
// FIXME: this background image doesn't exist
background: #C3E1FF url("/images/inst_tree/node-drag.gif") left 3px no-repeat;
}
&.leaf {