don't fail the external feed job on insecure url

fixes CNVS-39953

test plan:
- try to enter an blacklisted url as an external feed
- the job should still run

Change-Id: I302203b2f1502ca9bf767916b2287649a3cb0f63
Reviewed-on: https://gerrit.instructure.com/129746
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
This commit is contained in:
Simon Williams 2017-10-13 15:29:11 -06:00
parent bcd8183d48
commit 1cd230a7b2
1 changed files with 7 additions and 1 deletions

View File

@ -93,7 +93,13 @@ class ExternalFeedAggregator
@logger.info("request failed #{response.class}")
handle_failure(feed)
end
rescue CanvasHttp::Error, CanvasHttp::RelativeUriError, Timeout::Error, SocketError, SystemCallError => e
rescue CanvasHttp::Error,
CanvasHttp::RelativeUriError,
CanvasHttp::InsecureUriError,
Timeout::Error,
SocketError,
SystemCallError => e
@logger.info("request error: #{e}")
handle_failure(feed)
end