ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid divide by zero on zero point assignments; fixes #10472 

Change-Id: If4f68dfec6bb1152f1c590d329912e1b56bd4676
Reviewed-on: https://gerrit.instructure.com/13621
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
This commit is contained in:
Jacob Fugal 2012-09-11 10:59:48 -06:00
parent f2ca10d43a
commit 19b07928dc
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/models/assignment.rb
View File

@ -517,8 +517,14 @@ class Assignment < ActiveRecord::Base
end
def score_to_grade_percent(score=0.0)
result = score.to_f / self.points_possible
result = (result * 1000.0).round / 10.0
if self.points_possible > 0
result = score.to_f / self.points_possible
result = (result * 1000.0).round / 10.0
else
# there's not really any reasonable value we can set here -- if the
# assignment is worth no points, any percentage is as valid as any other.
score.to_f
end
end
def score_to_grade(score=0.0, given_grade=nil)