From 1699f6139923c702e1d5f280029f2954e81b4ab2 Mon Sep 17 00:00:00 2001 From: Ryan Shaw Date: Mon, 21 Oct 2019 15:59:25 -0600 Subject: [PATCH] help webpack know it can dead-code-eliminate ui-testable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Test plan: * run webpack in prod mode * you should not see the string “Could not append locator attribute” Anywhere in the public/dist/webpack-production folder * the main webpack bundle should be smaller Change-Id: Id5bf89d09d5e8c49c01da24780d792834143e534 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/214121 Tested-by: Jenkins Reviewed-by: Clay Diffrient QA-Review: Ryan Shaw Product-Review: Ryan Shaw --- frontend_build/baseWebpackConfig.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend_build/baseWebpackConfig.js b/frontend_build/baseWebpackConfig.js index f435d8f429a..c1c8651e1f6 100644 --- a/frontend_build/baseWebpackConfig.js +++ b/frontend_build/baseWebpackConfig.js @@ -299,7 +299,8 @@ module.exports = { new webpack.EnvironmentPlugin({ NODE_ENV: null, DEPRECATION_SENTRY_DSN: null, - GIT_COMMIT: null + GIT_COMMIT: null, + ALWAYS_APPEND_UI_TESTABLE_LOCATORS: null }), // Only include timezone data starting from 2011 (canvaseption) to 15 years from now,