deduplicate yarn.lock
refs DE-397 De-duplicating yarn.lock is necessary for some future InstUI upgrade work. In order to do this, we need to patch karma-webpack to avoid watching too many files within our JS job. We also need to pin babel-plugin-dynamic-import-node to the latest to work around a breaking change that causes “request of a dependency is an expression”. Both of these version pins are work arounds and will be addressed by our efforts to upgrade webpack to v5. Test Plan: 1. Ensure that “yarn dedupe-yarn” does not produce any file changes. 2. Ensure that the “JS (Karma)” job does not produce any warnings like “request of a dependency is an expression” 3. Ensure that the “JS (Karma)” job does not produce any warnings like “System limit for number of file watchers reached” 4. Ensure that Canvas front-end builds & behaves properly Change-Id: I94d77bd775bc12f9f96ac44640c862ff3e3dee79 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/256674 Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com> Reviewed-by: Ahmad Amireh <ahmad@instructure.com> QA-Review: Ahmad Amireh <ahmad@instructure.com> Product-Review: Ahmad Amireh <ahmad@instructure.com>
This commit is contained in:
parent
3ee1d2d747
commit
149f47778b
|
@ -254,7 +254,8 @@
|
|||
"karma-sourcemap-loader": "^0.3",
|
||||
"karma-spec-reporter": "^0.0.32",
|
||||
"karma-verbose-reporter": "^0.0.6",
|
||||
"karma-webpack": "^3",
|
||||
"karma-webpack": "necessary until https://github.com/ryanclark/karma-webpack/pull/449 is merged",
|
||||
"karma-webpack": "instructure/karma-webpack#patch1",
|
||||
"lint-staged": "^9",
|
||||
"merge-stream": "^2",
|
||||
"mockdate": "^2.0.2",
|
||||
|
@ -345,6 +346,8 @@
|
|||
"resolutions": {
|
||||
"jquery": "https://github.com/instructure/jquery.git#1.7.2-with-AMD-and-CommonJS",
|
||||
"graphael": "this is just here so yarn.lock looks the same whether the analytics plugin is checked out or not",
|
||||
"graphael": "https://github.com/instructure/graphael.git"
|
||||
"graphael": "https://github.com/instructure/graphael.git",
|
||||
"babel-plugin-dynamic-import-node": "if we let this upgrade to recent versions, we hit https://github.com/babel/babel/issues/11607",
|
||||
"babel-plugin-dynamic-import-node": "2.3.0"
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue