tweaks to dynamodb docker-compose setup

- gets rid of container_name, as this explicit name breaks from the
   pattern used in the rest of the codebase.
 - gets rid of env vars for AWS creds as they're unnecessary, and could
   potentially interfere with other aws libs besides dynammodb.
 - removes `links` as its deprecated and redundant with `depends_on`
 - adds "VIRTUAL_{HOST,PORT}" for dinghy

also fixes a typo in an old data fixup

Change-Id: Ie5953d1ee89d9e40779fe8f3e6c56731f77684d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246061
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>

docker-compose/dynamodb.override.yml

@@ -1,20 +1,15 @@
 # to use this for global lookups add docker-compose/dynamodb.override.yml
 # to your COMPOSE_FILE var in .env
-# Then:
-# - Run `GlobalLookups.initialize_ddb_for_development!` from a console
+# Then run:
+# $ docker-compose run --rm web bin/rails runner GlobalLookups::DevUtils.initialize_ddb_for_development!
 version: '2.3'
 services:
   web:
     depends_on:
-      - "dynamodb"
-    links:
       - dynamodb
-    environment:
-      AWS_ACCESS_KEY_ID: 'DUMMYIDEXAMPLE'
-      AWS_SECRET_ACCESS_KEY: 'DUMMYEXAMPLEKEY'
 
   dynamodb:
     image: instructure/dynamo-local-admin:latest
-    container_name: dynamodb-local
-    ports:
-      - "8000:8000"
+    environment:
+      VIRTUAL_HOST: dynamodb.docker
+      VIRTUAL_PORT: 8000

lib/data_fixup/initialize_submission_cached_due_date.rb

@@ -19,7 +19,7 @@ module DataFixup::InitializeSubmissionCachedDueDate
   def self.run
     Course.find_in_batches do |courses|
       courses.each do |course|
-        DueDateCacher.recompute_course(course, inst_job_opts: { priority: Delayed::LOWER_PRIORITY })
+        DueDateCacher.recompute_course(course, inst_jobs_opts: { priority: Delayed::LOWER_PRIORITY })
       end
     end
   end

lib/stubs/global_lookups.rb

@@ -22,9 +22,11 @@ module GlobalLookups
     end
   end
 
-  unless singleton_class.method_defined?(:initialize_ddb_for_development!)
-    def self.initialize_ddb_for_development!
-      puts("Nothing to do for global lookups stub")
+  module DevUtils
+    unless singleton_class.method_defined?(:initialize_ddb_for_development!)
+      def self.initialize_ddb_for_development!
+        puts("Nothing to do for global lookups stub")
+      end
     end
   end
 end