ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

set gradebook2 concluded enrollment spec back to pending. 

spec breaks on a6f77fc because concluded enrollments are hid
without a way to include them in the view.

temp. fix by setting this spec to pending until we implement
filtering.

Change-Id: Icdbce81cc72e75b7af6e165e60ad2fabd1d03b5a
Reviewed-on: https://gerrit.instructure.com/9132
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
This commit is contained in:
Zach Pendleton 2012-03-02 09:39:00 -07:00
parent a826b30053
commit 132ec17f93
1 changed files with 11 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
spec/selenium/gradebook2_spec.rb
View File

@ -562,25 +562,28 @@ describe "gradebook2" do
it "should not throw an error when setting the default grade when concluded enrollments exist" do it "should not throw an error when setting the default grade when concluded enrollments exist" do
pending("bug 7413 - Error assigning default grade for all students when one student's enrollment has been concluded.") do pending("bug 7413 - Error assigning default grade for all students when one student's enrollment has been concluded.") do
conclude_and_unconclude_course conclude_and_unconclude_course
3.times do 3.times { student_in_course }
student_in_course
end
get "/courses/#{@course.id}/gradebook2" get "/courses/#{@course.id}/gradebook2"
wait_for_ajaximations wait_for_ajaximations
#TODO - when show concluded enrollments fix goes in we probably have to add that code right here #TODO - when show concluded enrollments fix goes in we probably have to add that code right here
#for the test to work correctly #for the test to work correctly
set_default_grade(4, 5) set_default_grade(2, 5)
driver.find_element(:css, '.error_text').should_not be_displayed
keep_trying_until do keep_trying_until do
driver.switch_to.alert.should_not be_nil driver.switch_to.alert.should_not be_nil
driver.switch_to.alert.dismiss driver.switch_to.alert.dismiss
true
end end
driver.switch_to.default_content driver.switch_to.default_content
grade_grid = driver.find_element(:css, '#gradebook_grid') grade_grid = driver.find_element(:css, '#gradebook_grid')
StudentEnrollment.count.times do |n|
find_slick_cells(n, grade_grid)[2].text.should == expected_grade @course.student_enrollments.each_with_index do |e, n|
next if e.completed?
find_slick_cells(n, grade_grid)[2].text.should == 5
end end
end end
end end
@ -621,32 +624,6 @@ describe "gradebook2" do
find_slick_cells(1, driver.find_element(:css, '#gradebook_grid'))[0].text.should == curved_grade_text find_slick_cells(1, driver.find_element(:css, '#gradebook_grid'))[0].text.should == curved_grade_text
end end
it "should not throw an error when setting the default grade when concluded enrollments exist" do
conclude_and_unconclude_course
3.times do
student_in_course
end
get "/courses/#{@course.id}/gradebook2"
wait_for_ajaximations
#TODO - when show concluded enrollments fix goes in we probably have to add that code right here
#for the test to work correctly
set_default_grade 2
keep_trying_until do
driver.switch_to.alert.should_not be_nil
driver.switch_to.alert.dismiss
true
end
driver.switch_to.default_content
grade_grid = driver.find_element(:css, '#gradebook_grid')
StudentEnrollment.all.each_with_index do |e, n|
next if e.completed?
find_slick_cells(n, grade_grid)[2].text.should == '5'
end
end
it "should handle multiple enrollments correctly" do it "should handle multiple enrollments correctly" do
@course.student_enrollments.create!(:user => @student_1, :course_section => @other_section) @course.student_enrollments.create!(:user => @student_1, :course_section => @other_section)