ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

skipped spec cleanup 

deleting old unneeded and specs and tagging tickets to specs that need
to be fixed and unskipped in the future

flag=none
closes EVAL-2433

Test Plan:
    -specs pass

Change-Id: Iaee922288b842054afece69617c064e3d449c6bc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293888
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Kai Bjorkman <kbjorkman@instructure.com>
This commit is contained in:
Kai Bjorkman 2022-06-13 14:37:02 -06:00
parent 6edd1fc788
commit 11d231136d
16 changed files with 200 additions and 222 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spec/selenium/admin/sub_accounts/rubrics_spec.rb
View File

@ -51,9 +51,4 @@ describe "sub account shared rubric specs" do
it "rounds to an integer when splitting" do
should_round_to_an_integer_when_splitting
end
it "picks the lower value when splitting without room for an integer" do
skip("fragile - need to refactor split_ratings method")
should_pick_the_lower_value_when_splitting_without_room_for_an_integer
end
end

2
spec/selenium/grades/grade_validation/grade_validation_spec.rb
View File

@ -24,7 +24,7 @@ describe "Gradebook frontend/backend calculators" do
include_context "in-process server selenium tests"
before :once do
skip("Unskip in GRADE-1871")
skip("Unskip in EVAL-2496")
@unlucky1 = [95.86, 66.62, 76.98, 87.85, 68.32, 94.32, 62.6, 81.59, 92.21, 90.31, 82.26, 70.88, 83.24, 90.83, 65.74, 73.05, 94.16, 65.3, 78.92, 87.11]
@unlucky2 = [93.33, 88.32, 61.29, 83.57, 86.61, 77.36, 84.72, 63.51, 78.43, 82.44, 85.3, 65.51, 81.29, 76.52, 90.13, 71.1, 61.56, 90.05, 67.07, 96.76]
@unlucky3 = [95.36, 90.12, 62.08, 91.67, 87.34, 77.01, 75.63, 64.18, 81.69, 65.87, 73.38, 91.17, 85.68, 72.33, 70.4, 74.86, 63.74, 96.16, 62.09, 97.29]

2
spec/selenium/grades/moderation/moderated_marking_spec.rb
View File

@ -251,7 +251,7 @@ describe "Moderated Marking" do
end
it "selects the custom grade", priority: "1" do
skip("unskip this in GRADE-1615 once this is not flaky using using the most recent InstUI")
skip("unskip this in EVAL-2500 once this is not flaky using using the most recent InstUI")
# the aria-activedescendant will be the id of the selected option
selected_id = ModeratePage.grade_input(@student1).attribute("aria-activedescendant")

5
spec/selenium/grades/rubric/rubrics_teacher_spec.rb
View File

@ -49,11 +49,6 @@ describe "teacher shared rubric specs" do
it "rounds to an integer when splitting" do
should_round_to_an_integer_when_splitting
end
it "picks the lower value when splitting without room for an integer" do
skip("fragile - need to refactor split_ratings method")
should_pick_the_lower_value_when_splitting_without_room_for_an_integer
end
end
describe "course rubrics" do

2
spec/selenium/grades/speedgrader/speedgrader_student_group_filter_spec.rb
View File

@ -97,7 +97,7 @@ describe "filter speed grader by student group" do
end
it "loads speedgrader when group selected" do
skip("Unskip in GRADE-2245")
skip("Unskip in EVAL-2501")
# select group from gradebook setting
@teacher.preferences[:gradebook_settings] = {
@course.id => {

2
spec/selenium/grades/speedgrader/speedgrader_teacher_spec.rb
View File

@ -212,7 +212,7 @@ describe "speed grader" do
end
it "sorts by submission status when eg_sort_by is submission_status" do
skip "update => update! made this spec fail GRADE-1086"
skip "update => update! made this spec fail EVAL-2502"
@submission1 = @assignment.submit_homework(@student1, submission_type: "online_text_entry", body: "student one")
@submission2 = @assignment.submit_homework(@student2, submission_type: "online_text_entry", body: "student three")
@submission2.update!(

24
spec/selenium/helpers/rubrics_common.rb
View File

@ -95,19 +95,6 @@ module RubricsCommon
fj(".rubric .edit_rubric_link:visible").click
end
# should be in editing mode before calling
def split_ratings(idx)
rating = ffj(".rubric .criterion:visible .rating")[idx]
driver.action.move_to(rating).perform
driver.execute_script <<~JS
var $rating = $('.rubric .criterion:visible .rating:eq(#{idx})');
$rating.addClass('add_column add_left');
$rating.prev().addClass('add_right');
$rating.click();
JS
end
def should_delete_a_rubric
create_rubric_with_criterion_points "5"
f(".delete_rubric_link").click
@ -153,17 +140,6 @@ module RubricsCommon
expect(ffj(".rubric .criterion:visible .rating .points")[1].text).to eq "3"
end
def should_pick_the_lower_value_when_splitting_without_room_for_an_integer
create_rubric_with_criterion_points "0.5"
edit_rubric_after_updating
split_ratings(1)
wait_for_ajaximations
wait_for_dom_ready
expect(ffj(".rubric .criterion:visible .rating .points").count).to eq 3
expect(ffj(".rubric .criterion:visible .rating .points")[1].text).to eq "0"
end
def import_outcome
f("#right-side .edit_rubric_link").click
wait_for_ajaximations

317
spec/selenium/performance/grades/gradebook_performance_spec.rb
View File

@ -17,186 +17,185 @@
# You should have received a copy of the GNU Affero General Public License along
# with this program. If not, see <http://www.gnu.org/licenses/>.
require_relative "../../common"
require_relative "../../grades/pages/gradebook_page"
require_relative "../../grades/pages/speedgrader_page"
# require_relative "../../common"
# require_relative "../../grades/pages/gradebook_page"
# require_relative "../../grades/pages/speedgrader_page"
# total course enrollments = 1 teacher + student(s)
# the following array =
# [no of student enrollments, no of assignments in each course:assignment_group]
# So @courses[0] will have 4001 total enrollments and 50 assignments
student_assignments = [
[4000, 50],
[2000, 50],
[1000, 100],
[200, 50]
]
# student_assignments = [
# [4000, 50],
# [2000, 50],
# [1000, 100],
# [200, 50]
# ]
describe "Gradebook performance" do
include_context "in-process server selenium tests"
# describe "Gradebook performance" do
# include_context "in-process server selenium tests"
before :once do
grades_sample = (60.0..100.0).step(0.01).map { |x| x.round(2) }
# before :once do
# grades_sample = (60.0..100.0).step(0.01).map { |x| x.round(2) }
@courses = []
(1..4).each do |i|
course = course_factory(course_name: "My Course #{i}", active_course: true)
@courses.push course
end
@course1 = @courses[0]
@course2 = @courses[1]
@course3 = @courses[2]
@course4 = @courses[3]
# @courses = []
# (1..4).each do |i|
# course = course_factory(course_name: "My Course #{i}", active_course: true)
# @courses.push course
# end
# @course1 = @courses[0]
# @course2 = @courses[1]
# @course3 = @courses[2]
# @course4 = @courses[3]
# enroll a teacher in each course
@teacher = course_with_teacher(course: @courses.first, name: "Dedicated Teacher1", active_user: true, active_enrollment: true).user
(1..3).each do |i|
@courses[i].enroll_user(@teacher, "TeacherEnrollment", allow_multiple_enrollments: true, enrollment_state: "active")
end
# # enroll a teacher in each course
# @teacher = course_with_teacher(course: @courses.first, name: "Dedicated Teacher1", active_user: true, active_enrollment: true).user
# (1..3).each do |i|
# @courses[i].enroll_user(@teacher, "TeacherEnrollment", allow_multiple_enrollments: true, enrollment_state: "active")
# end
@students = create_users(student_assignments[0][0], return_type: :record, name_prefix: "Jack")
# @students = create_users(student_assignments[0][0], return_type: :record, name_prefix: "Jack")
@assignments_array = []
(0..3).each do |i|
# enroll students in each course
students = @students.first(student_assignments[i][0])
create_enrollments(@courses[i], students, allow_multiple_enrollments: true)
# @assignments_array = []
# (0..3).each do |i|
# # enroll students in each course
# students = @students.first(student_assignments[i][0])
# create_enrollments(@courses[i], students, allow_multiple_enrollments: true)
# create an assignment group for each course
group = AssignmentGroup.suspend_callbacks(:update_student_grades) do
@courses[i].assignment_groups.create! name: "assignments"
end
# # create an assignment group for each course
# group = AssignmentGroup.suspend_callbacks(:update_student_grades) do
# @courses[i].assignment_groups.create! name: "assignments"
# end
# create no of assignments in each course:assignment_group
assignments = create_assignments(
[@courses[i].id],
student_assignments[i][1],
points_possible: 100.0,
submission_types: "online_text_entry,online_upload",
assignment_group_id: group.id
)
@assignments_array.push assignments
end
# # create no of assignments in each course:assignment_group
# assignments = create_assignments(
# [@courses[i].id],
# student_assignments[i][1],
# points_possible: 100.0,
# submission_types: "online_text_entry,online_upload",
# assignment_group_id: group.id
# )
# @assignments_array.push assignments
# end
@assignments_array.each_with_index do |assignments, index|
students = @students.first(student_assignments[index][0])
create_records(Submission, assignments.map do |id|
students.map do |student|
grade = grades_sample.sample
{
course_id: @courses[index].id,
assignment_id: id,
user_id: student.id,
body: "hello",
workflow_state: "graded",
submission_type: "online_text_entry",
grader_id: @teacher.id,
score: grade,
grade: grade.to_s,
graded_at: Time.zone.now,
grade_matches_current_submission: true
}
end
end.flatten)
end
# @assignments_array.each_with_index do |assignments, index|
# students = @students.first(student_assignments[index][0])
# create_records(Submission, assignments.map do |id|
# students.map do |student|
# grade = grades_sample.sample
# {
# course_id: @courses[index].id,
# assignment_id: id,
# user_id: student.id,
# body: "hello",
# workflow_state: "graded",
# submission_type: "online_text_entry",
# grader_id: @teacher.id,
# score: grade,
# grade: grade.to_s,
# graded_at: Time.zone.now,
# grade_matches_current_submission: true
# }
# end
# end.flatten)
# end
@assignments1 = @assignments_array[0]
@assignments2 = @assignments_array[1]
@assignments3 = @assignments_array[2]
@assignments4 = @assignments_array[3]
end
# @assignments1 = @assignments_array[0]
# @assignments2 = @assignments_array[1]
# @assignments3 = @assignments_array[2]
# @assignments4 = @assignments_array[3]
# end
before do
user_session(@teacher)
end
# before do
# user_session(@teacher)
# end
context "200,000 submissions" do
it "gradebook loads in less than 25 seconds" do
page_load_start_time = Time.zone.now
Gradebook.visit(@course1)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Gradebook Submissions:200,000 Expected_Load:25 Actual_Load:#{load_time}"
expect(load_time).to be < 25
end
# context "200,000 submissions" do
# it "gradebook loads in less than 25 seconds" do
# page_load_start_time = Time.zone.now
# Gradebook.visit(@course1)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Gradebook Submissions:200,000 Expected_Load:25 Actual_Load:#{load_time}"
# expect(load_time).to be < 25
# end
it "speedgrader loads in less than 100 seconds" do
skip("load times are pretty inconsistent")
page_load_start_time = Time.zone.now
Speedgrader.visit(@course1.id, @assignments1[0], 60)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Speedgrader Submissions:200,000 Expected_Load:100 Actual_Load:#{load_time}"
expect(load_time).to be < 100
end
end
# it "speedgrader loads in less than 100 seconds" do
# page_load_start_time = Time.zone.now
# Speedgrader.visit(@course1.id, @assignments1[0], 60)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Speedgrader Submissions:200,000 Expected_Load:100 Actual_Load:#{load_time}"
# expect(load_time).to be < 100
# end
# end
context "100,000 submissions 2000x50" do
it "gradebook loads in less than 25 seconds" do
page_load_start_time = Time.zone.now
Gradebook.visit(@course2)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Gradebook Submissions:100,000_2000x50 Expected_Load:25 Actual_Load:#{load_time}"
expect(load_time).to be < 25
end
# context "100,000 submissions 2000x50" do
# it "gradebook loads in less than 25 seconds" do
# page_load_start_time = Time.zone.now
# Gradebook.visit(@course2)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Gradebook Submissions:100,000_2000x50 Expected_Load:25 Actual_Load:#{load_time}"
# expect(load_time).to be < 25
# end
it "speedgrader loads in less than 45 seconds" do
page_load_start_time = Time.zone.now
Speedgrader.visit(@course2.id, @assignments2[0], 60)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Speedgrader Submissions:100,000_2000x50 Expected_Load:45 Actual_Load:#{load_time}"
expect(load_time).to be < 45
end
end
# it "speedgrader loads in less than 45 seconds" do
# page_load_start_time = Time.zone.now
# Speedgrader.visit(@course2.id, @assignments2[0], 60)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Speedgrader Submissions:100,000_2000x50 Expected_Load:45 Actual_Load:#{load_time}"
# expect(load_time).to be < 45
# end
# end
context "100,000 submissions 1000x100" do
it "gradebook loads in less than 25 seconds" do
page_load_start_time = Time.zone.now
Gradebook.visit(@course3)
wait_for_ajaximations
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Gradebook Submissions:100,000_1000x100 Expected_Load:25 Actual_Load:#{load_time}"
expect(load_time).to be < 25
end
# context "100,000 submissions 1000x100" do
# it "gradebook loads in less than 25 seconds" do
# page_load_start_time = Time.zone.now
# Gradebook.visit(@course3)
# wait_for_ajaximations
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Gradebook Submissions:100,000_1000x100 Expected_Load:25 Actual_Load:#{load_time}"
# expect(load_time).to be < 25
# end
it "speedgrader loads in less than 19 seconds" do
page_load_start_time = Time.zone.now
Speedgrader.visit(@course3.id, @assignments3[0], 60)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Speedgrader Submissions:100,000_2000x50 Expected_Load:19 Actual_Load:#{load_time}"
expect(load_time).to be < 19
end
end
# it "speedgrader loads in less than 19 seconds" do
# page_load_start_time = Time.zone.now
# Speedgrader.visit(@course3.id, @assignments3[0], 60)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Speedgrader Submissions:100,000_2000x50 Expected_Load:19 Actual_Load:#{load_time}"
# expect(load_time).to be < 19
# end
# end
context "10,000 submissions" do
it "gradebook loads in less than 18 seconds" do
page_load_start_time = Time.zone.now
Gradebook.visit(@course4)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Gradebook Submissions:10,000 Expected_Load:18 Actual_Load:#{load_time}"
expect(load_time).to be < 18
end
# context "10,000 submissions" do
# it "gradebook loads in less than 18 seconds" do
# page_load_start_time = Time.zone.now
# Gradebook.visit(@course4)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Gradebook Submissions:10,000 Expected_Load:18 Actual_Load:#{load_time}"
# expect(load_time).to be < 18
# end
it "speedgrader loads in less than 10 seconds" do
page_load_start_time = Time.zone.now
Speedgrader.visit(@course4.id, @assignments4[0], 60)
wait_for_ajaximations
page_load_end_time = Time.zone.now
load_time = page_load_end_time - page_load_start_time
puts "\nPage:Speedgrader Submissions:10,000 Expected_Load:10 Actual_Load:#{load_time}"
expect(load_time).to be < 10
end
end
end
# it "speedgrader loads in less than 10 seconds" do
# page_load_start_time = Time.zone.now
# Speedgrader.visit(@course4.id, @assignments4[0], 60)
# wait_for_ajaximations
# page_load_end_time = Time.zone.now
# load_time = page_load_end_time - page_load_start_time
# puts "\nPage:Speedgrader Submissions:10,000 Expected_Load:10 Actual_Load:#{load_time}"
# expect(load_time).to be < 10
# end
# end
# end

2
ui/features/assignments_show_student/react/__tests__/StudentViewIntegration.test.js
View File

@ -126,6 +126,7 @@ describe('student view integration tests', () => {
// displayed happens as a result of a cache write and these higher level
// components re-rendering
it.skip('displays the new file after it has been uploaded', async () => {
// unskip in EVAL-2503
window.URL.createObjectURL = jest.fn()
uploadFileModule.uploadFile = jest.fn()
uploadFileModule.uploadFile.mockReturnValueOnce({id: '1', name: 'test.jpg'})
@ -236,6 +237,7 @@ describe('student view integration tests', () => {
// Skipping these tests as logged out user is not currently handled
// properly in Assignments2 due to graphql issues
describe.skip('logged out user on a public assignment', () => {
// unskip in EVAL-2503
async function createPublicAssignmentMocks(overrides = {}) {
const query = LOGGED_OUT_STUDENT_VIEW_QUERY
const variables = {assignmentLid: '1'}

3
ui/features/assignments_show_student/react/components/AttemptType/__tests__/MediaAttempt.test.js
View File

@ -94,12 +94,14 @@ describe('MediaAttempt', () => {
})
it.skip('renders the current submission draft', async () => {
// unskip in EVAL-2504
const props = await makeProps(submissionDraftOverrides)
const {getByTestId} = render(<MediaAttempt {...props} />)
expect(getByTestId('media-recording')).toBeInTheDocument()
})
it.skip('removes the current submission draft when the media is removed', async () => {
// unskip in EVAL-2504
const props = await makeProps(submissionDraftOverrides)
const {getByTestId} = render(<MediaAttempt {...props} />)
const trashButton = getByTestId('remove-media-recording')
@ -116,6 +118,7 @@ describe('MediaAttempt', () => {
})
describe.skip('submitted', () => {
// unskip in EVAL-2504
it('renders the current submission', async () => {
const props = await makeProps({
Submission: {

3
ui/features/assignments_show_student/react/components/__tests__/CommentsTextArea.test.js
View File

@ -319,6 +319,7 @@ describe('CommentTextArea', () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('notifies users when a submission comments with files is sent', async () => {
// unskip in EVAL-2482
const mockedFunctionPlacedholder = uploadFileModule.submissionCommentAttachmentsUpload
uploadFileModule.submissionCommentAttachmentsUpload = () => [
{id: '1', name: 'awesome-test-image1.png'},
@ -366,6 +367,7 @@ describe('CommentTextArea', () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('users cannot send submission comments with not files or text', async () => {
// unskip in EVAL-2482
const mockedFunctionPlacedholder = uploadFileModule.submissionCommentAttachmentsUpload
uploadFileModule.submissionCommentAttachmentsUpload = () => [
{id: '1', name: 'awesome-test-image1.png'},
@ -397,6 +399,7 @@ describe('CommentTextArea', () => {
// eslint-disable-next-line jest/no-disabled-tests
it.skip('notifies users of error when file fails to upload', async () => {
// unskip in EVAL-2482
const mockedFunctionPlacedholder = uploadFileModule.submissionCommentAttachmentsUpload
uploadFileModule.submissionCommentAttachmentsUpload = () => {
throw new Error('Error uploading file to canvas API')

1
ui/features/assignments_show_student/react/components/__tests__/CommentsTrayBody.test.js
View File

@ -243,6 +243,7 @@ describe.skip('CommentsTrayBody', () => {
// https://instructure.atlassian.net/browse/USERS-379
// eslint-disable-next-line jest/no-disabled-tests
it.skip('renders error alert when data returned from mutation fails', async () => {
// To be unskipped in EVAL-2477
const mocks = await Promise.all([mockSubmissionCommentQuery(), mockCreateSubmissionComment()])
mocks[1].error = new Error('aw shucks')
const props = await mockAssignmentAndSubmission()

2
ui/features/assignments_show_student/react/components/__tests__/StudentContent.test.js
View File

@ -134,6 +134,7 @@ describe('Assignment Student Content View', () => {
})
it.skip('renders the rubric if the assignment has one', async () => {
// unskip in EVAL-1679
window.ENV.ASSIGNMENT_ID = 1
window.ENV.COURSE_ID = 1
props.assignment.rubric = {}
@ -239,6 +240,7 @@ describe('Assignment Student Content View', () => {
// https://instructure.atlassian.net/browse/USERS-385
// eslint-disable-next-line jest/no-disabled-tests
it.skip('renders Comments', async () => {
// To be unskipped in EVAL-1679
const mocks = await makeMocks()
const props = await mockAssignmentAndSubmission()
const {getByText} = render(

32
ui/features/screenreader_gradebook/ember/tests/integration/item_selection.spec.js
View File

@ -28,12 +28,7 @@ const buttonDisabled = (trigger, expectedBoolean) =>
const checkSelection = (id, selection) => equal(id, find(selection).val())
const checkSelectedText = (text, selection) =>
equal(
text,
find(selection)
.find('option:selected')
.text()
)
equal(text, find(selection).find('option:selected').text())
const checkText = (selector, expectedText) =>
equal(Ember.$.trim(find(`.assignmentsPanel ${selector}`).text()), expectedText)
@ -105,7 +100,7 @@ test('Previous buttons are disabled', () => {
})
// compares & checks before/after objects
test('clicking Next Student button displays next student', function() {
test('clicking Next Student button displays next student', function () {
const before = this.controller.get('selectedStudent')
checkSelection(before.id, '#student_select')
return click('.student_navigation .next_object:first').then(() => {
@ -118,7 +113,7 @@ test('clicking Next Student button displays next student', function() {
})
// compares & checks before/after objects
test('clicking Next Assignment button displays next assignment', function() {
test('clicking Next Assignment button displays next assignment', function () {
const before = this.controller.get('selectedAssignment')
checkSelection(before.id, '#assignment_select')
return click('.assignment_navigation .next_object').then(() => {
@ -206,7 +201,7 @@ test('Next Assignment button is disabled', () =>
buttonDisabled('.assignment_navigation .next_object', true))
// compares & checks before/after objects
test('clicking Previous Student button displays previous student', function() {
test('clicking Previous Student button displays previous student', function () {
const before = this.controller.get('selectedStudent')
checkSelection(before.id, '#student_select')
return click('.student_navigation .previous_object:first').then(() => {
@ -219,7 +214,7 @@ test('clicking Previous Student button displays previous student', function() {
})
// compares & checks before/after objects
test('clicking Previous Assignment button displays previous assignment', function() {
test('clicking Previous Assignment button displays previous assignment', function () {
const before = this.controller.get('selectedAssignment')
checkSelection(before.id, '#assignment_select')
return click('.assignment_navigation .previous_object').then(() => {
@ -265,7 +260,7 @@ QUnit.module('screenreader_gradebook assignment navigation: display update', {
}
})
test('screenreader_gradebook assignment selection: grade for field updates', function() {
test('screenreader_gradebook assignment selection: grade for field updates', function () {
const assignment_name_selector = "label[for='student_and_assignment_grade']"
const selectedAssigName = this.controller.get('selectedAssignment.name')
@ -299,7 +294,7 @@ QUnit.module('screenreader_gradebook assignment navigation: assignment sorting',
}
})
test('alphabetical', function() {
test('alphabetical', function () {
const before = this.controller.get('assignments.firstObject')
Ember.run(() =>
this.controller.set(
@ -316,7 +311,7 @@ test('alphabetical', function() {
)
})
test('due date', function() {
test('due date', function () {
const before = this.controller.get('assignments.firstObject')
Ember.run(() =>
this.controller.set(
@ -333,7 +328,7 @@ test('due date', function() {
)
})
test('changing sorting option with selectedAssignment', function() {
test('changing sorting option with selectedAssignment', function () {
// SORT BY: alphabetical
Ember.run(() =>
this.controller.set(
@ -403,7 +398,7 @@ QUnit.module('screenreader_gradebook student navigation: section selection', {
}
})
test('prev/next still work', function() {
test('prev/next still work', function () {
buttonDisabled('.student_navigation .previous_object:first', true)
buttonDisabled('.student_navigation .next_object:first', false)
@ -430,7 +425,7 @@ test('prev/next still work', function() {
})
})
test('resets selectedStudent when student is not in both sections', function() {
test('resets selectedStudent when student is not in both sections', function () {
return click('.student_navigation .next_object:first').then(() => {
const firstStudent = this.controller.get('selectedStudent')
@ -449,7 +444,7 @@ test('resets selectedStudent when student is not in both sections', function() {
})
})
test('maintains selectedStudent when student is in both sections and updates navigation points', function() {
test('maintains selectedStudent when student is in both sections and updates navigation points', function () {
Ember.run(() =>
// requires a fixture for a student with enrollment in 2 sections
// and a previous/next option for all sections
@ -511,7 +506,8 @@ QUnit.module(
}
)
QUnit.skip('aria-announcer', function() {
// unskip in EVAL-2505
QUnit.skip('aria-announcer', function () {
equal(Ember.$.trim(find('.aria-announcer').text()), '')
click('.student_navigation .next_object:first').then(() => {

10
ui/features/screenreader_gradebook/ember/tests/integration/settings.spec.js
View File

@ -41,16 +41,15 @@ test('student names are hidden', () => {
const selection = '#student_select option[value=1]'
equal($(selection).text(), 'Barnes, Bob')
return click('#hide_names_checkbox').then(() => {
$(selection)
.text()
.search('Student') !== -1
$(selection).text().search('Student') !== -1
return click('#hide_names_checkbox').then(() => {
equal($(selection).text(), 'Barnes, Bob')
})
})
})
QUnit.skip('secondary id says hidden', function() {
// unskip in EVAL-2505
QUnit.skip('secondary id says hidden', function () {
Ember.run(() => {
const student = this.controller.get('students.firstObject')
Ember.setProperties(student, {
@ -67,7 +66,8 @@ QUnit.skip('secondary id says hidden', function() {
})
})
QUnit.skip('view concluded enrollments', function() {
// unskip in EVAL-2505
QUnit.skip('view concluded enrollments', function () {
let enrollments = this.controller.get('enrollments')
ok(enrollments.content.length > 1)
enrollments.content.forEach(enrollment => ok(enrollment.workflow_state === undefined))

10
ui/features/screenreader_gradebook/ember/tests/integration/ungraded.spec.js
View File

@ -46,7 +46,10 @@ QUnit.module('include ungraded assignments setting:false', {
}
})
QUnit.skip('clicking the ungraded checkbox updates includeUngradedAssignments to true', () => runTest())
// unskip in EVAL-2505
QUnit.skip('clicking the ungraded checkbox updates includeUngradedAssignments to true', () =>
runTest()
)
QUnit.module('include ungraded assignments setting:true', {
setup() {
@ -58,4 +61,7 @@ QUnit.module('include ungraded assignments setting:true', {
}
})
QUnit.skip('clicking the ungraded checkbox updates includeUngradedAssignments to false', () => runTest())
// unskip in EVAL-2505
QUnit.skip('clicking the ungraded checkbox updates includeUngradedAssignments to false', () =>
runTest()
)