ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't log errors on every key up/down in speedGrader 

this is a fix for the speedGrader typing becoming
really unresponsive after time.

fixes #5171

Change-Id: I87771b11f926761b17d69645bede899b7caaecec
Reviewed-on: https://gerrit.instructure.com/5475
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
This commit is contained in:
Ryan Shaw 2011-09-07 20:59:48 -06:00
parent 05c45bf4a0
commit 0e28ffd926
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
public/javascripts/instructure_helper.js
View File

@ -3444,6 +3444,14 @@ I18n.scoped('instructure', function(I18n) {
scribdDoc.addEventListener('iPaperReady', opts.ready);
}
scribdDoc.write( id );
// this is a hack so that the <embed> doesn't throw a bunch of these errors after it is .remove()d:
// Uncaught TypeError: Object #<HTMLEmbedElement> has no method 'keyboardShortcut(Up/Down)'
// They come from the actionscript running in their viewer:
// see: http://dragstudio.com/app/ScribdViewer/javascript/_-0j.as
// and http://groups.google.com/group/scribd-platform-developers/msg/46a4f12db73d02d8
this.childNodes[0].keyboardShortcutDown = this.childNodes[0].keyboardShortcutUp = function(){};
tellAppIViewedThisInline();
} else if (!INST.disableGooglePreviews && (!opts.mimeType || $.isPreviewable(opts.mimeType, 'google')) && opts.attachment_id || opts.public_url){
// else if it's something google docs preview can handle and we can get a public url to this document.