sending last name to turnitin

test plan
* submit assignment to turnitin
* verify that canvas gets an originality score
* verify that the student's last name in turnitin is their last name (not 'Student')
	* for students with no last name in canvas we still send 'Student'

Change-Id: I1e66ae0041be26b82ebed9324d7cde3057047048
Reviewed-on: https://gerrit.instructure.com/14566
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
This commit is contained in:
Brad Humphrey 2012-10-04 16:36:49 -06:00
parent 3a294e9b43
commit 0bfde2aa66
2 changed files with 21 additions and 2 deletions

View File

@ -313,8 +313,9 @@ module Turnitin
params[:ufn] = user.name
params[:uln] = "Course"
else
params[:ufn] = user.name
params[:uln] = "Student"
params[:ufn] = user.first_name
params[:uln] = user.last_name
params[:uln] = "Student" if params[:uln].empty?
end
end
if course

View File

@ -169,6 +169,24 @@ describe Turnitin::Client do
@turnitin_api.request_md5(md5_params).should eql(post_params[:md5])
end
it "should get a first and last name for users" do
args = @turnitin_submit_args.clone
args[:user].name = "User"
params = @turnitin_api.prepare_params(:create_user, '2', args)
params[:ufn].should=="User"
params[:uln].should_not be_empty
args = @turnitin_submit_args.clone
args[:user].name = "First Last"
args[:user].sortable_name = "Last, First"
params = @turnitin_api.prepare_params(:create_user, '2', args)
params[:ufn].should=="First"
params[:uln].should=="Last"
end
end
describe "#request_md5" do