From 0a394efa1b84e225a04c18f60432545f51934f04 Mon Sep 17 00:00:00 2001 From: Davis Hyer Date: Wed, 22 Sep 2021 09:21:24 -0600 Subject: [PATCH] provide correct open prop type MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit flag=none test plan: - specs pass qa risk: low Change-Id: I87b4cab226a401e1a46f5ee15827e3192d8ad978 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274130 Tested-by: Service Cloud Jenkins Reviewed-by: Omar Soto-Fortuño QA-Review: Omar Soto-Fortuño Product-Review: Omar Soto-Fortuño --- jest/jest-setup.js | 1 - .../containers/ComposeModalContainer/ComposeModalContainer.js | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/jest/jest-setup.js b/jest/jest-setup.js index 87a521627f9..d17673300ea 100644 --- a/jest/jest-setup.js +++ b/jest/jest-setup.js @@ -70,7 +70,6 @@ const ignoredErrors = [ /Invalid prop `heading` of type `object` supplied to `Billboard`/, // https://instructure.atlassian.net/browse/QUIZ-8870 /Invalid prop `headingAs` of value `h4` supplied to `Billboard`/, /Invalid prop `id` of type `number` supplied to `Option`/, - /Invalid prop `open` of type `number` supplied to `(Modal|ModalSpinner)`/, /Invalid prop `outcomesGroup.contextId` of type `number` supplied to `FindOutcomesView`, expected `string`/, /Invalid prop `returnFocusTo` of type `DeprecatedComponent` supplied to `(CourseHomeDialog|HomePagePromptContainer)`/, /Invalid prop `selectedDate` of type `date` supplied to `CanvasDateInput`/, diff --git a/ui/features/inbox/react/containers/ComposeModalContainer/ComposeModalContainer.js b/ui/features/inbox/react/containers/ComposeModalContainer/ComposeModalContainer.js index d7a64d35d56..1be30f4df8c 100644 --- a/ui/features/inbox/react/containers/ComposeModalContainer/ComposeModalContainer.js +++ b/ui/features/inbox/react/containers/ComposeModalContainer/ComposeModalContainer.js @@ -214,7 +214,7 @@ const ComposeModalContainer = props => { label={I18n.t('Uploading Files')} message={I18n.t('Please wait while we upload attachments')} onExited={() => sendMessage()} - open={props.sendingMessage && attachmentsToUpload.length} + open={props.sendingMessage && !!attachmentsToUpload.length} /> )