ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

provide correct open prop type 

flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I87b4cab226a401e1a46f5ee15827e3192d8ad978
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274130
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
This commit is contained in:
Davis Hyer 2021-09-22 09:21:24 -06:00
parent 6b0271a7a5
commit 0a394efa1b
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jest/jest-setup.js
View File

@ -70,7 +70,6 @@ const ignoredErrors = [
/Invalid prop `heading` of type `object` supplied to `Billboard`/, // https://instructure.atlassian.net/browse/QUIZ-8870
/Invalid prop `headingAs` of value `h4` supplied to `Billboard`/,
/Invalid prop `id` of type `number` supplied to `Option`/,
/Invalid prop `open` of type `number` supplied to `(Modal|ModalSpinner)`/,
/Invalid prop `outcomesGroup.contextId` of type `number` supplied to `FindOutcomesView`, expected `string`/,
/Invalid prop `returnFocusTo` of type `DeprecatedComponent` supplied to `(CourseHomeDialog|HomePagePromptContainer)`/,
/Invalid prop `selectedDate` of type `date` supplied to `CanvasDateInput`/,

2
ui/features/inbox/react/containers/ComposeModalContainer/ComposeModalContainer.js
View File

@ -214,7 +214,7 @@ const ComposeModalContainer = props => {
label={I18n.t('Uploading Files')}
message={I18n.t('Please wait while we upload attachments')}
onExited={() => sendMessage()}
open={props.sendingMessage && attachmentsToUpload.length}
open={props.sendingMessage && !!attachmentsToUpload.length}
/>
</>
)