ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spec: ensure sis export report includes suspended users 

closes FOO-2415

Change-Id: Ibc277a371d0acde1b10de9d4601294d700be5505
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276562
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
This commit is contained in:
Cody Cutrer 2021-10-21 16:02:48 -06:00
parent fc538f4336
commit 099f2f63f9
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gems/plugins/account_reports/spec_canvas/sis_provisioning_reports_spec.rb
View File

@ -57,6 +57,9 @@ describe "Default Account Reports" do
@user8 = user_with_pseudonym(:active_all => true, :username => 'steve@apple.com', @user8 = user_with_pseudonym(:active_all => true, :username => 'steve@apple.com',
:name => 'Steve Jobs', :account => @account) :name => 'Steve Jobs', :account => @account)
@user8.destroy @user8.destroy
@user9 = user_with_pseudonym(:active_all => true, :username => 'tim@apple.com',
:name => 'Tim Cook', :account => @account)
@user9.pseudonym.update!(workflow_state: 'suspended')
end end
def create_an_account def create_an_account
@ -332,7 +335,7 @@ describe "Default Account Reports" do
name_parts = User.name_parts(user.sortable_name, likely_already_surname_first: true) name_parts = User.name_parts(user.sortable_name, likely_already_surname_first: true)
first_name = name_parts[0] first_name = name_parts[0]
last_name = name_parts[1] last_name = name_parts[1]
state = user.workflow_state == 'registered' ? 'active' : user.workflow_state state = pseudonym.workflow_state
@report ||= AccountReports::SisExporter.new(@account.account_reports.new(user: @admin), {}) @report ||= AccountReports::SisExporter.new(@account.account_reports.new(user: @admin), {})
row = case format row = case format
when 'sis' when 'sis'
@ -449,8 +452,8 @@ describe "Default Account Reports" do
headers = parsed.shift headers = parsed.shift
expect(headers).to eq user_headers(format: 'provisioning') expect(headers).to eq user_headers(format: 'provisioning')
expect(parsed.length).to eq 6 expect(parsed.length).to eq 7
expect(parsed).to eq([@user6, @user7, @user1, @user2, @user3, @user4].map { |u| expected_user(u, format: 'provisioning') }) expect(parsed).to eq([@user6, @user7, @user9, @user1, @user2, @user3, @user4].map { |u| expected_user(u, format: 'provisioning') })
end end
it "runs provisioning report including deleted users for course" do it "runs provisioning report including deleted users for course" do